Calling `setup:config:set` results in checking `pub/media` files permissions

[lbajsarowicz]

Preconditions and environment

• Magento 2.4.6-p3

Steps to reproduce

1. Install Vanilla Magento
2. Connect to the server and change random file permissions in pub/media to non-writeable
3. Call bin/magento setup:config:set with any change

Expected result

The configuration is updated, no error thrown.

Actual result

bin/magento setup:config:set --no-interaction --cache-id-prefix=9b27b_ --page-cache-id-prefix=9b27b_
In ConfigModel.php line 171:

Missing write permissions to the following paths:                            
   /home/jetrails/xxx.com/releases/20240208120923/pub/media/logo.png

Additional information

The issue is in \Magento\Framework\Setup\FilePermissions::getMissingWritablePathsForInstallation, for some reason it not only validates permissions to write to the required directory, but also all the directories and files in it.

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @lbajsarowicz. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

Hello @lbajsarowicz,

Thank you for the report and collaboration!

This seems like expected behaviour, could you tell us more why is this an issue and when are you experiencing this.

Thank you.

[lbajsarowicz]

@engcom-November For one of our Clients, graphics in pub/media are uploaded using SFTP. The ownership of those files do not allow Magento to write to those files. Agent responsible for uploading files does not have option to either change ownership or file permissions in their software. As a result, after each batch of graphics being delivered, the deployment fails.

[engcom-November]

Hello @lbajsarowicz,

Thank you for the quick respose!

As from your recent comment, I understand getMissingWritablePathsForInstallation method is fetching the non-writable files inside pub/media, but as these files are non writable, you need a way to deploy without getting write permission error.

I believe this falls under feature request, as \Magento\Framework\Setup\FilePermissions by default will check permissions for all the files and folders inside a directory.

Please let us know your input on this.

Thank you.

[lbajsarowicz]

@engcom-November Althoguh I can understand validating write permissions to var/ directory, I do not understand the requirement of writeability of all the directories and files in pub/media being writeable.

Do you have any Issue number, Jira Ticket number or any other source that would explain the root cause for introducing such a validation?

[engcom-November]

@lbajsarowicz, please take a look here, this is the documentation for setting up the ownership for development and production system, it is mentioned that pub/media must be writable.

[lbajsarowicz]

@engcom-November Unfortunately, that document does not answer WHY enterprise users can't just follow their content security policies (assets writeable only by specific *nix group).

Secondly, why the error is triggered... during setup:config:set, neither with setup:db-data:upgrade nor setup:upgrade.

I would even understand this check with setup:install, but checking file permissions when you change cache key - I think there's a glitch implemented in the core.

[engcom-November]

@lbajsarowicz, It is a valid issue if the error is only triggered when running the setup:config:set command, and not with other commands.
Hence this issue can be confirmed.

Thank you.