Skip to content

Only add 24h to toTimeStamp if no time has been given #38496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from
Open

Only add 24h to toTimeStamp if no time has been given #38496

wants to merge 2 commits into from

Conversation

indykoning
Copy link

@indykoning indykoning commented Mar 7, 2024 •
edited by m2-assistant bot
Loading

Description (*)

This PR updates the dateTo check to check wether the timestamp is 00:00:00 before adding 24 hours.
Ensuring the old behaviour works as expected. However allowing passing in a time without 24 hours being forced onto the date.

Manual testing scenarios (*)

  1. Execute isScopeDateInInterval() with the scope, from day, and to date only being a date
  2. Check that 24 hours has been added to the ToDate
  3. Execute isScopeDateInInterval() with the scope, from day, and to date being a date with a time
  4. Check that 24 hours has not been added and it matches the exact time given

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Only add 24h to toTimeStamp if no time has been given #38513: Only add 24h to toTimeStamp if no time has been given

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Mar 7, 2024

Hi @indykoning. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@indykoning
Copy link
Author

@magento run all tests

@engcom-Hotel engcom-Hotel added Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Mar 12, 2024
@engcom-Hotel
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Mar 12, 2024
Open
5 tasks
@indykoning
Copy link
Author

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbclaudio jbclaudio jbclaudio approved these changes

Assignees
No one assigned
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Only add 24h to toTimeStamp if no time has been given
3 participants
@indykoning @engcom-Hotel @jbclaudio