Open
Description
This issue is automatically created based on existing pull request: #38493: Extend Observer declaration in events.xml by new attribute ifconfig
Description (*)
Extension of Observer declaration in events.xml by new optional attribute ifconfig with appropriate handling of it.
Similar to usage of ifconfig in layout's xml files - it executes (or not) Observer depending on boolean value of given config path. The purpose is to condition Observer's execution on config paths representing module's state - usually <module/general/active> or <module/general/enabled> etc.
Manual testing scenarios (*)
- Add ifconfig attribute to Observer A declaration in events.xml file where its value will be config path and dispatch event to trigger Observer.
a) When config path value equals to true - Observer should execute.
b) When config path value equals to false - Observer should not execute
c) When config does not exist (path does not represent any actual value) - Observer should not execute - Add ifconfig attribute to Observer A declaration in events.xml file where its value is empty string "" and dispatch event to trigger Observer. Observer should execute.
Contribution checklist (*)
- Pull request has a meaningful description of its purposeAll commits are accompanied by meaningful commit messagesAll new or changed code is covered with unit/integration tests (if applicable)README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an updateAll automated tests passed successfully (all builds are green)
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
Pull Request in Progress
Activity
m2-assistant commentedon Apr 8, 2024
Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇
Area: XXXXX
label to the ticket, indicating the functional areas it may be related to.2.4-develop
branchDetails
- Add the comment@magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure.- If the issue is reproducible on
2.4-develop
branch, please, add the labelReproduced on 2.4.x
.- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
Issue: Confirmed
once verification is complete.engcom-November commentedon Apr 8, 2024
Hello @bartekAtconvert,
Thank you for the report and collaboration!
As you are adding a new attribute
ifconfig
toevents.xml
, so that the observer's execution can be conditioned.This can be considered as a feature request. Hence marking it the same.
Thank you.