Skip to content

[Issue] Fix parameter type #38529

Open
@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #38520: Fix parameter type


Description (*)

This parameter is actually an array when passed from \Magento\ImportExport\Controller\Adminhtml\Export\Export::execute and \Magento\ImportExport\Model\Export\Entity\ExportInfoFactory::getEntityAdapter does expect it as an array as well.

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Set a debugger in the method and create an export via adminhtml. You will see it is an array.
  2. Look at \Magento\ImportExport\Model\Export\Entity\ExportInfoFactory::getEntityAdapter it does type it as an array.

Questions or comments

This should have been caught by static tests such as phpstan.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Metadata

Metadata

Assignees

Labels

Area: Import / exportComponent: ImportExportIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: ready for confirmationPriority: P2A defect with this priority could have functionality issues which are not to expectations.Progress: PR in progressReported on 2.4.xIndicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchTriage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject it

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions