Closed
Description
This issue is automatically created based on existing pull request: #38554: Remove scope resolver usage
Description (*)
Admin URL settings is global and shouldn't be loaded depending on the current store.
Metadata
Metadata
Assignees
Labels
Gate 3 Passed. Manual verification of the issue completed. Issue is confirmedA defect with this priority could have functionality issues which are not to expectations.Indicates original Magento version for the Issue report.The issue has been reproduced on latest 2.4-develop branchIssue related to Developer Experience and needs help with Triage to Confirm or Reject it
Activity
m2-assistant commentedon Apr 4, 2024
Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇
Area: XXXXX
label to the ticket, indicating the functional areas it may be related to.2.4-develop
branchDetails
- Add the comment@magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure.- If the issue is reproducible on
2.4-develop
branch, please, add the labelReproduced on 2.4.x
.- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
Issue: Confirmed
once verification is complete.engcom-November commentedon Apr 4, 2024
Hello @thomas-kl1,
Thank you for the report and collaboration!
Verified this on 2.4-develop.
In
app/code/Magento/Backend/App/Area/FrontNameResolver::isHostBackend()
we do not need to pass the scope in$this->scopeConfig->getValue()
, as Admin URL is global, insteaddefault
scope should be used.Hence this issue can be confirmed.
Thank you.
github-jira-sync-bot commentedon Apr 4, 2024
✅ Jira issue https://jira.corp.adobe.com/browse/AC-11736 is successfully created for this GitHub issue.
6 remaining items