Skip to content

[Issue] Remove scope resolver usage #38566

Closed
@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #38554: Remove scope resolver usage


Description (*)

Admin URL settings is global and shouldn't be loaded depending on the current store.

Activity

added
Priority: P2A defect with this priority could have functionality issues which are not to expectations.
on Apr 2, 2024
added
Triage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject it
on Apr 3, 2024
m2-assistant

m2-assistant commented on Apr 4, 2024

@m2-assistant
Author

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
    3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    5. Add label Issue: Confirmed once verification is complete.
    6. Make sure that automatic system confirms that report has been added to the backlog.
engcom-November

engcom-November commented on Apr 4, 2024

@engcom-November
Contributor

Hello @thomas-kl1,

Thank you for the report and collaboration!

Verified this on 2.4-develop.
In app/code/Magento/Backend/App/Area/FrontNameResolver::isHostBackend() we do not need to pass the scope in $this->scopeConfig->getValue(), as Admin URL is global, instead default scope should be used.
Hence this issue can be confirmed.

Thank you.

github-jira-sync-bot

github-jira-sync-bot commented on Apr 4, 2024

@github-jira-sync-bot

✅ Jira issue https://jira.corp.adobe.com/browse/AC-11736 is successfully created for this GitHub issue.

6 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Area: FrameworkComponent: BackendIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: ready for confirmationPriority: P2A defect with this priority could have functionality issues which are not to expectations.Progress: PR in progressReported on 2.4.xIndicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchTriage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject it

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Participants

    @thomas-kl1@engcom-Bravo@engcom-November@engcom-Dash@github-jira-sync-bot

    Issue actions

      [Issue] Remove scope resolver usage · Issue #38566 · magento/magento2