Skip to content

Email template store-switcher #38892

Open
@vandijkstef

Description

@vandijkstef

Preconditions and environment

  • Mage 2.4.7
  • comes with module-newsletter@100.4.7

Steps to reproduce

  • Open an email template preview (newsletter module)
  • Try to open the store switcher

Expected result

An opened store switcher

Actual result

Click is ignored, nothing happens.

Additional information

Magento/Module_Newsletter/view/adminhtml/templates/preview/iframeswitcher.phtml is containing deprecated jQuery 'onload' code.

Currently:

jQuery("#preview_iframe").load(function() {
    jQuery(this).height(jQuery(this).contents().find("html").height() );
});

Needs to be:

jQuery("#preview_iframe").on('load', function() {
    jQuery(this).height(jQuery(this).contents().find("html").height() );
});

Furthermore there needs to be checked where ).load( is still being used.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
    Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
    Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
    Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
    Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

Activity

m2-assistant

m2-assistant commented on Jul 2, 2024

@m2-assistant

Hi @vandijkstef. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

self-assigned this
on Jul 2, 2024
m2-assistant

m2-assistant commented on Jul 2, 2024

@m2-assistant

Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
    1. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

engcom-Dash

engcom-Dash commented on Jul 4, 2024

@engcom-Dash
Contributor

Hi @vandijkstef

Thanks for reporting and collaboration.

Verified the issue on the Magento 2.4 dev instance and the issue is reproducible.

Click is ignored, nothing happens when the Newsletter template is opened and try to switch store

Steps to reproduce
Open an email template preview (newsletter module)
Try to open the store switcher

Please refer to the attached screen recording.

38892_Confirmed.mov
github-jira-sync-bot

github-jira-sync-bot commented on Jul 4, 2024

@github-jira-sync-bot

✅ Jira issue https://jira.corp.adobe.com/browse/AC-12334 is successfully created for this GitHub issue.

m2-assistant

m2-assistant commented on Jul 4, 2024

@m2-assistant

✅ Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

added
Priority: P2A defect with this priority could have functionality issues which are not to expectations.
on Jul 4, 2024

23 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Area: Admin UIComponent: EmailIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P2A defect with this priority could have functionality issues which are not to expectations.Progress: PR in progressReported on 2.4.7Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branch

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Participants

    @vandijkstef@lucafuser@engcom-Hotel@engcom-Dash@github-jira-sync-bot

    Issue actions

      Email template store-switcher · Issue #38892 · magento/magento2