Hi @quterorta. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@magento run all tests

@magento run all tests

@quterorta I am taking care of the test case fixes. Thank You!

@magento run all tests

@magento run Unit Tests, Static Tests

@magento run all tests

Hi @quterorta,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

• Install fresh Magento 2.4-develop

Steps to reproduce

• Create a couple of cart rules (or more than 2 rules) with the next params:
• Rule name: {your rule name}
• Conditions: Apply for all product
• Action:

• Apply: Percent of product price discount
  

• Discount Amount: {some discount amount}
  

• Discard subsequent rules: No
  

• Add some products to the cart and place an order.
• After that, get order data via the next API REST endpoint: rest/V1/orders/{order_id}
• Check the discount_percent field for the item
• Calculate the price after discount by yourself: {base_price} * ((100-{discount_percent})/100)
• Calculated price must be equal to the {row_total} value

Before: ✖️ 

After: ✔️

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

@magento run all tests

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

Two of the Functional EE Test failures are inconsistent and seems to be flaky. They neither part of PR nor failing because of the PR changes. The consistent failure is a known issue.

Functional Tests EE:

Build 1: Allure Report - EE

Build 2: Allure Report - EE

Known Issue:

StorefrontAssertAsLowAsLabelTest: ACQE-7645

Hence Moving this PR in Merge In Progress

cc @sidolov @engcom-Hotel what do you think?

Hello @Den4ik,

You are right, the current discount calculation is working as below:

However, the current implementation calculates it like this:

1. 10% of $100 = $10
2. 5% of ($100 - $10) = 5% of $90 = $4.5

Please refer to the below screenshot from this page, which says the same thing on discount calculation:

Hi @engcom-Hotel
But I didn't find in documentation any information that second rule applies to the discounted price (after rule 1). Documentation mention only product price.
In my opinion product price and cart item price (after applying discount) are not the same.

Moving this pull request (PR) to On Hold status due to the ongoing discussion.

Hello @Den4ik,

As per our discussion on Slack, your concern is regarding the calculation of two cart price rules, 10% and 5%, applied as Percent of product price discount. Instead of the following calculation:

1. 10% of $100 = $10
2. 5% of ($100 - $10) = 5% of $90 = $4.5
3. Final discounted Price $90 - $4.5 = $85.5

It should calculate as below:

1. 10% + 5% = 15%
2. 15% of $100 = $15
3. Final discounted Price $100 - $15 = $85

Please confirm, if I understood correct.

Thanks

Hi @engcom-Hotel

Please confirm, if I understood correct.

You understood correctly. I see 2 possible solutions:

1. Update documentation and mention that next rules apply to cart item price after previous rules
2. Update logic and use product price for all rules

Hello @Den4ik,

We are currently discussing this with the internal team and will update you accordingly.

Thanks