[Bug] $quote can be null. Module: module-payment-services-paypal

[sgeleon]

Summary

magento/product-community-edition: v2.4.7-p1

This plugin has some issues. The $quote can be null, but this possibility isn't accounted for in the plugin's definition.

Examples

vendor/magento/module-payment-services-paypal/Plugin/Vault/Method.php:59

public function afterIsAvailable(VaultMethod $subject, bool $result, **CartInterface $quote**): bool

vendor/magento/module-vault/Model/Method/Vault.php:659

 public function isAvailable(\Magento\Quote\Api\Data\CartInterface **$quote = null**)

Proposed solution

Patch for fix this problem:

Index: vendor/magento/module-payment-services-paypal/Plugin/Vault/Method.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/vendor/magento/module-payment-services-paypal/Plugin/Vault/Method.php b/vendor/magento/module-payment-services-paypal/Plugin/Vault/Method.php
--- a/vendor/magento/module-payment-services-paypal/Plugin/Vault/Method.php	
+++ b/vendor/magento/module-payment-services-paypal/Plugin/Vault/Method.php	(date 1714131569327)
@@ -56,9 +56,9 @@
      * @param CartInterface $quote
      * @return bool
      */
-    public function afterIsAvailable(VaultMethod $subject, bool $result, CartInterface $quote): bool
+    public function afterIsAvailable(VaultMethod $subject, bool $result, CartInterface $quote = null): bool
     {
-        if ($subject->getCode() === HostedFieldsConfigProvider::CC_VAULT_CODE) {
+        if ($quote && $subject->getCode() === HostedFieldsConfigProvider::CC_VAULT_CODE) {
             if ($customerId = $quote->getCustomerId()) {
                 return !empty($this->tokenManagement->getVisibleAvailableTokens($customerId));
             }

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @sgeleon. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

Hello @sgeleon,

Thank you for the report and collaboration!

Can you let us know what is the impact of this issue.

[sgeleon]

Hi @engcom-November

I described the issue in the description of this bug report.

In the module Magento_PaymentServicesPaypal, we are using the class Magento\PaymentServicesPaypal\Plugin\Vault\Method to replace the class \Magento\Vault\Model\Method\Vault from the module Magento_Vault.

We are having a problem with defining variables in the class we are patching.

vendor/magento/module-payment-services-paypal/Plugin/Vault/Method.php:59

public function afterIsAvailable(VaultMethod $subject, bool $result, **CartInterface $quote**): bool

vendor/magento/module-vault/Model/Method/Vault.php:659

 public function isAvailable(\Magento\Quote\Api\Data\CartInterface **$quote = null**)

[engcom-November]

Hello @sgeleon,

Since $quote can be null, and not being defined in afterIsAvailable method may cause problem when calling $quote->getCustomerId().
Hence confirming this.

Thank you.