Open
Description
This issue is automatically created based on existing pull request: #37411: Unpack object arguments as named parameters
Description (*)
Just a code clean up that uses PHP 8.1 feature of unpacking array with named params.
So array_values
call is not needed anymore. Probably improve overrall performance by 0.01 :D as many objects will instantiate faster
Related Pull Requests
Fixed Issues (if relevant)
- Fixes magento/magento2#<issue_number>
Manual testing scenarios (*)
- ...
- ...
Questions or comments
Named argumaents are actualy a bit faster based on simple check for instantiatin 100 000 objects like this
https://pastebin.com/DGdBwwzN
Contribution checklist (*)
- Pull request has a meaningful description of its purposeAll commits are accompanied by meaningful commit messagesAll new or changed code is covered with unit/integration tests (if applicable)README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an updateAll automated tests passed successfully (all builds are green)
Activity
github-jira-sync-bot commentedon Oct 3, 2024
✅ Jira issue https://jira.corp.adobe.com/browse/AC-13210 is successfully created for this GitHub issue.
m2-assistant commentedon Oct 3, 2024
✅ Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.