Skip to content

[Issue] Unpack object arguments as named parameters #39233

Open
@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #37411: Unpack object arguments as named parameters


Description (*)

Just a code clean up that uses PHP 8.1 feature of unpacking array with named params.
So array_values call is not needed anymore. Probably improve overrall performance by 0.01 :D as many objects will instantiate faster

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Named argumaents are actualy a bit faster based on simple check for instantiatin 100 000 objects like this
https://pastebin.com/DGdBwwzN
Selection_177

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
    All commits are accompanied by meaningful commit messages
    All new or changed code is covered with unit/integration tests (if applicable)
    README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
    All automated tests passed successfully (all builds are green)

Activity

added
Priority: P2A defect with this priority could have functionality issues which are not to expectations.
on Oct 3, 2024
github-jira-sync-bot

github-jira-sync-bot commented on Oct 3, 2024

@github-jira-sync-bot

✅ Jira issue https://jira.corp.adobe.com/browse/AC-13210 is successfully created for this GitHub issue.

m2-assistant

m2-assistant commented on Oct 3, 2024

@m2-assistant
Author

✅ Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Area: FrameworkComponent: Framework/ComponentIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P2A defect with this priority could have functionality issues which are not to expectations.Progress: PR in progressReported on 2.4.xIndicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branch

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Participants

    @ilnytskyi@engcom-Dash@github-jira-sync-bot

    Issue actions

      [Issue] Unpack object arguments as named parameters · Issue #39233 · magento/magento2