Skip to content

Fix import iframe visibility #39265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: 2.4-develop
Choose a base branch
from
Open

Fix import iframe visibility #39265

wants to merge 4 commits into from

Conversation

DmitryFurs
Copy link
Contributor

@DmitryFurs DmitryFurs commented Oct 15, 2024 •
edited by m2-assistant bot
Loading

Description

An iframe is displayed at the bottom of the import page during validation and subsequent data import

The display attribute with the value none is added to the iframe, previously it was style="display:none", but during refactoring this was incorrectly changed.

Related Commit

1edf224#diff-3160ffecaaf7ab21ba68a3b535d34ab5719602af66952aabe8a821cfac42da9aR172

Manual testing scenarios (*)

  1. Go to the import page in the admin panel
  2. Select any type of entity
  3. Upload the file for import
  4. Click "Check data"
  5. Click "Import"
  6. Scroll window to the bottom

image

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Fix import iframe visibility #39267: Fix import iframe visibility

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Oct 15, 2024

Hi @DmitryFurs. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@DmitryFurs
Copy link
Contributor Author

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Oct 16, 2024
Open
5 tasks
@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review
Projects
Pull Requests Dashboard
Status: Pending Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Fix import iframe visibility
2 participants
@DmitryFurs @engcom-Hotel