Skip to content

[Issue] Sitemap fix error in case of image with null Title or Caption #39410

Closed
@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #37462: Sitemap fix error in case of image with null Title or Caption


Description (*)

This patch fixes Patch to fix Argument 1 passed to Magento\Sitemap\Model\Sitemap::escapeXmlText() must be of the type string, null given when the given title or caption are null.

Manual testing scenarios (*)

  1. Add a sitemap image with a title or caption with the value null.
  2. The Sitemap model should no longer return an error.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
    All commits are accompanied by meaningful commit messages
    All new or changed code is covered with unit/integration tests (if applicable)
    README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
    All automated tests passed successfully (all builds are green)

Activity

added
Priority: P2A defect with this priority could have functionality issues which are not to expectations.
on Nov 29, 2024
engcom-Bravo

engcom-Bravo commented on Dec 6, 2024

@engcom-Bravo
Contributor

Hi @RPrudon,

Thanks for your reporting and collaboration.

Please refer this comment #37462 (comment) and provide more information to reproduce the issue.

Thanks.

self-assigned this
on Dec 6, 2024
m2-assistant

m2-assistant commented on Dec 6, 2024

@m2-assistant
Author

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
    3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    5. Add label Issue: Confirmed once verification is complete.
    6. Make sure that automatic system confirms that report has been added to the backlog.
added
Issue: needs updateAdditional information is require, waiting for response
Reported on 2.4.xIndicates original Magento version for the Issue report.
on Dec 6, 2024
engcom-Bravo

engcom-Bravo commented on Dec 26, 2024

@engcom-Bravo
Contributor

Hi @RPrudon,

This issue is being closed since it has not been updated in a long time.Please feel free to reopen or raise a new ticket if the issue still exists.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Issue: needs updateAdditional information is require, waiting for responsePriority: P2A defect with this priority could have functionality issues which are not to expectations.Progress: doneReported on 2.4.xIndicates original Magento version for the Issue report.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Participants

    @engcom-Bravo

    Issue actions

      [Issue] Sitemap fix error in case of image with null Title or Caption · Issue #39410 · magento/magento2