Skip to content

URL switch problem in a store with a redirection that exists in another store #39470

Open
@Yoann-D

Description

@Yoann-D

Preconditions and environment

  • Magento version 2.4.7-p3
  • Do not use the $oldStore to fetch existing urlwrites

Steps to reproduce

  • Have multiple Websites and multiples stores
  • Create a custom redirection for a website A on a URL common to different websites (blog to blogs for example)
  • Go to Website B, and on the blog page, make a store switch

Expected result

The Rewrite url created for another website A must not have any link with Website B

Actual result

For code in file : vendor/magento/module-url-rewrite/Model/StoreSwitcher/RewriteUrl.php ligne 80
image

Currently my store IDs on my website B are 7 and 25.

The code returns me a redirect to website A

image

So we have $existingRewrite is yes and $currentRewrite is false . So we are sent back to the BaseUrl

image

The problem in the $existing write variable, we will not filter with the $oldStoreId

To correct this I added the $oldStoreId in the filter

image

Additional information

This my fix
switcher.zip

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
    Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
    Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
    Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
    Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

Activity

m2-assistant

m2-assistant commented on Dec 12, 2024

@m2-assistant

Hi @Yoann-D. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

added
Triage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject it
Reported on 2.4.7-p3Indicates original Magento version for the Issue report.
on Dec 12, 2024
self-assigned this
on Dec 12, 2024
m2-assistant

m2-assistant commented on Dec 12, 2024

@m2-assistant

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
    3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    5. Add label Issue: Confirmed once verification is complete.
    6. Make sure that automatic system confirms that report has been added to the backlog.
engcom-Hotel

engcom-Hotel commented on Dec 12, 2024

@engcom-Hotel
Contributor

Hello @Yoann-D,

Thanks for the report and collaboration!

We request you to please elaborate more on the below steps (If possible share screencast to demonstrate):

  • Create a custom redirection for a website A on a URL common to different websites (blog to blogs for example)
  • Go to Website B, and on the blog page, make a store switch

Thanks

moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Boardon Dec 12, 2024

24 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Area: FrameworkComponent: CmsUrlRewriteIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P3May be fixed according to the position in the backlog.Progress: ready for devReported on 2.4.7-p3Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchTriage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject it

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Participants

    @Yoann-D@engcom-Bravo@engcom-Hotel@github-jira-sync-bot@Sathakathulla-S

    Issue actions

      URL switch problem in a store with a redirection that exists in another store · Issue #39470 · magento/magento2