Description (*)

When URL rewrite has the same values for request_path and target_path it falls down into an infinite loop, so in this PR added condition to break the loop to prevent such situations.

The problem is in this code snippet:

private function findFinalUrl(UrlRewrite $urlRewrite): UrlRewrite
{
    do {
        $nextUrlRewrite = $this->findUrlFromRequestPath(
            $urlRewrite->getTargetPath(),
            (int) $urlRewrite->getStoreId()
        );
        if ($nextUrlRewrite) {
            $urlRewrite = $nextUrlRewrite;
        }
    } while ($nextUrlRewrite);

    return $urlRewrite;
}

Related Pull Requests

...

Fixed Issues (if relevant)

1. Fixes [GraphQl] Route query infinite loop #39707

Manual testing scenarios (*)

1. Go to Magento Admin -> Marketing -> SEO & Search -> URL Rewrites

2. Create a new URL rewrite via Add URL Rewrite with following values:

   • Create URL Rewrite = Custom
   • Request Path = test
   • Target Path = test

3. Send the following GraphQl query:

{
  route(url: "/test") {
    relative_url
  }
}

4. The response should be:

{
  "errors": [
    {
      "message": "No such entity found with matching URL key: test",
      "locations": [
        {
          "line": 2,
          "column": 3
        }
      ],
      "path": [
        "route"
      ],
      "extensions": {
        "category": "graphql-no-such-entity"
      }
    }
  ],
  "data": {
    "route": null
  }
}

Questions or comments

...

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)