Typed variadic arguments fail to be injected

[adrian-martinez-interactiv4]

Description (*)

Related with #24556.

That PR allowed to inject scalar values as variadic parameters, but does not work for object injections. Object definitions don't get instantiated, and target class constructor receives an array of strings instead (with '_instance' key, that should have been transformed into real objects).

<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
  <!-- Declare di arguments injection -->
    <type name="Interactiv4\EmailAttachments\Mail\AttachmentsProcessor">
        <arguments>
            <!-- This argument is a typed variadic one -->
            <argument name="attachmentProviders" xsi:type="array">
                <!-- This argument value is an object implementing variadic argument type -->
                <item name="invoice" xsi:type="object">Interactiv4\SalesEmailAttachments\Mail\AttachmentProvider\InvoiceAttachmentProvider</item>
            </argument>
        </arguments>
    </type>
</config>

With proposed changes, variadic arguments are interpreted when needed to be transformed into real objects. Scalar/other variadic arguments will continue working as previously.

Second commit also fixes objects are not being injected into target class constructor when all this conditions are satisfied:

• Target class constructor has a single, variadic, constructor argument.
• A factory is used to inject variadic arguments dynamically.
• Running in compiled mode.

Related Pull Requests

#24556

Fixed Issues (if relevant)

1. resolves [Issue] Typed variadic arguments fail to be injected #30931: Typed variadic arguments fail to be injected

Manual testing scenarios (*)

1. Create a class with a typed variadic argument in it:

class Test
{
    public function __construct(SomeInterface ...$interfaceInstances){}
}

2. Inject via di.xml instances of given interface, similar as shown in summary.
3. Prior to this proposed change it fails complaining of type error on object construct.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @adrian-martinez-interactiv4. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[adrian-martinez-interactiv4]

@magento run all tests

[sidolov]

@magento create issue

[adrian-martinez-interactiv4]

@magento run all tests

[adrian-martinez-interactiv4]

@magento run all tests

[adrian-martinez-interactiv4]

@magento run all tests