From 0c9a7f00f8261409c159b7c1473caa60b17af14b Mon Sep 17 00:00:00 2001
From: Kate Kyzyma <kate@atwix.com>
Date: Tue, 4 Jan 2022 11:24:03 +0200
Subject: [PATCH 1/2] Refactoring-AdminCheckResultsOfColorAndOtherFiltersTest

---
 ...CheckResultsOfColorAndOtherFiltersTest.xml | 42 +++++++++++--------
 1 file changed, 25 insertions(+), 17 deletions(-)

diff --git a/app/code/Magento/ConfigurableProduct/Test/Mftf/Test/AdminCheckResultsOfColorAndOtherFiltersTest.xml b/app/code/Magento/ConfigurableProduct/Test/Mftf/Test/AdminCheckResultsOfColorAndOtherFiltersTest.xml
index f4cad6590e1f6..8b67f023c56a3 100644
--- a/app/code/Magento/ConfigurableProduct/Test/Mftf/Test/AdminCheckResultsOfColorAndOtherFiltersTest.xml
+++ b/app/code/Magento/ConfigurableProduct/Test/Mftf/Test/AdminCheckResultsOfColorAndOtherFiltersTest.xml
@@ -133,11 +133,14 @@
             <argument name="attributeCode" value="$$createConfigProductAttribute.attribute_code$$"/>
             <argument name="price" value="34"/>
         </actionGroup>
-        <waitForPageLoad stepKey="waitForPageLoad"/>
-        <click selector="{{CmsNewPagePageActionsSection.expandSplitButton}}"  stepKey="expandSplitBtnFirst" />
-        <click selector="{{CmsNewPagePageActionsSection.saveAndClose}}" stepKey="clickSaveAndCloseFirst"/>
-        <waitForPageLoad stepKey="waitForMessage"/>
-        <seeElement selector="{{AdminProductMessagesSection.successMessage}}" stepKey="seeSaveProductMessageFirst"/>
+        <comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="waitForPageLoad"/>
+        <comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="expandSplitBtnFirst"/>
+        <actionGroup ref="AdminFormSaveAndCloseActionGroup" stepKey="clickSaveAndCloseFirst"/>
+        <comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="waitForMessage"/>
+        <actionGroup ref="AssertMessageInAdminPanelActionGroup" stepKey="seeSaveProductMessageFirst">
+            <argument name="message" value="You saved the product."/>
+        </actionGroup>
+
         <!-- Edit created second product as configurable product with options -->
         <actionGroup ref="FilterProductGridBySkuActionGroup" stepKey="filterGridBySecondProduct">
             <argument name="product" value="$$createSecondConfigurableProduct$$"/>
@@ -156,11 +159,13 @@
             <argument name="price" value="34"/>
             <argument name="attributeOption" value="option5"/>
         </actionGroup>
-        <waitForPageLoad stepKey="waitForPageLoadThird"/>
-        <click selector="{{CmsNewPagePageActionsSection.expandSplitButton}}"  stepKey="expandSplitBtnSecond" />
-        <click selector="{{CmsNewPagePageActionsSection.saveAndClose}}" stepKey="clickSaveAndCloseSecond"/>
-        <waitForPageLoad stepKey="waitForSuccessMessage"/>
-        <seeElement selector="{{AdminProductMessagesSection.successMessage}}" stepKey="seeSaveProductMessageSecond"/>
+        <comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="waitForPageLoadThird"/>
+        <comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="expandSplitBtnSecond"/>
+        <actionGroup ref="AdminFormSaveAndCloseActionGroup" stepKey="clickSaveAndCloseSecond"/>
+        <comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="waitForSuccessMessage"/>
+        <actionGroup ref="AssertMessageInAdminPanelActionGroup" stepKey="seeSaveProductMessageSecond">
+            <argument name="message" value="You saved the product."/>
+        </actionGroup>
         <!-- Edit created third product as configurable product with options -->
         <actionGroup ref="FilterProductGridBySkuActionGroup" stepKey="filterGridByThirdProduct">
             <argument name="product" value="$$createThirdConfigurableProduct$$"/>
@@ -179,10 +184,12 @@
             <argument name="price" value="34"/>
             <argument name="attributeOption" value="option1"/>
         </actionGroup>
-        <click selector="{{CmsNewPagePageActionsSection.expandSplitButton}}"  stepKey="expandSplitBtnThird" />
-        <click selector="{{CmsNewPagePageActionsSection.saveAndClose}}" stepKey="clickSaveAndCloseThird"/>
-        <waitForPageLoad stepKey="waitForProductPage"/>
-        <seeElement selector="{{AdminProductMessagesSection.successMessage}}" stepKey="seeSaveConfigurableProductMessage"/>
+        <comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="expandSplitBtnThird"/>
+        <actionGroup ref="AdminFormSaveAndCloseActionGroup" stepKey="clickSaveAndCloseThird"/>
+        <comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="waitForProductPage"/>
+        <actionGroup ref="AssertMessageInAdminPanelActionGroup" stepKey="seeSaveConfigurableProductMessage">
+            <argument name="message" value="You saved the product."/>
+        </actionGroup>
         <!-- Create Simple product with options -->
         <actionGroup ref="FilterProductGridBySkuActionGroup" stepKey="filterGridBySimpleProduct">
             <argument name="product" value="$$createSimpleProduct$$"/>
@@ -196,9 +203,10 @@
             <argument name="label" value="mySet"/>
             <argument name="option1" value="['option1', 'option2']"/>
         </actionGroup>
-        <click selector="{{AdminGridMainControls.save}}" stepKey="clickToSaveProduct"/>
-        <waitForPageLoad stepKey="waitForNewSimpleProductPage"/>
-        <seeElement selector="{{AdminProductMessagesSection.successMessage}}" stepKey="seeSaveProductMessageThird"/>
+        <actionGroup ref="AdminProductFormSaveButtonClickActionGroup" stepKey="clickSaveButton"/>
+        <actionGroup ref="AssertMessageInAdminPanelActionGroup" stepKey="seeSaveProductMessageThird">
+            <argument name="message" value="You saved the product."/>
+        </actionGroup>
         <magentoCron stepKey="runCronIndex" groups="index"/>
     </test>
 </tests>

From a68d0bfab226a9d196362047ba73cc5e773a932c Mon Sep 17 00:00:00 2001
From: Kate Kyzyma <kate@atwix.com>
Date: Tue, 4 Jan 2022 15:24:13 +0200
Subject: [PATCH 2/2] Fix Semantic Version Checker issues

---
 .../Mftf/Test/AdminCheckResultsOfColorAndOtherFiltersTest.xml  | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/app/code/Magento/ConfigurableProduct/Test/Mftf/Test/AdminCheckResultsOfColorAndOtherFiltersTest.xml b/app/code/Magento/ConfigurableProduct/Test/Mftf/Test/AdminCheckResultsOfColorAndOtherFiltersTest.xml
index 8b67f023c56a3..bc6d140f4127d 100644
--- a/app/code/Magento/ConfigurableProduct/Test/Mftf/Test/AdminCheckResultsOfColorAndOtherFiltersTest.xml
+++ b/app/code/Magento/ConfigurableProduct/Test/Mftf/Test/AdminCheckResultsOfColorAndOtherFiltersTest.xml
@@ -203,7 +203,8 @@
             <argument name="label" value="mySet"/>
             <argument name="option1" value="['option1', 'option2']"/>
         </actionGroup>
-        <actionGroup ref="AdminProductFormSaveButtonClickActionGroup" stepKey="clickSaveButton"/>
+        <actionGroup ref="AdminProductFormSaveButtonClickActionGroup" stepKey="clickToSaveProduct"/>
+        <comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="waitForNewSimpleProductPage"/>
         <actionGroup ref="AssertMessageInAdminPanelActionGroup" stepKey="seeSaveProductMessageThird">
             <argument name="message" value="You saved the product."/>
         </actionGroup>