From 68566f7c9d1405fb8442dafa4550a7caa81fa1e0 Mon Sep 17 00:00:00 2001 From: Dan Wallis Date: Tue, 7 Mar 2023 14:13:18 +0000 Subject: [PATCH 1/5] Remove forbidden @author tag --- .../SalesRule/Model/ResourceModel/Report/Rule/Updatedat.php | 2 -- .../Model/ResourceModel/Report/Updatedat/Collection.php | 2 -- .../Magento/SalesRule/Model/ResourceModel/Rule/Customer.php | 2 -- .../SalesRule/Model/ResourceModel/Rule/Customer/Collection.php | 2 -- app/code/Magento/SalesRule/Model/Rule/Condition/Product.php | 2 -- app/code/Magento/SalesRule/Model/Rule/Customer.php | 2 -- .../SalesRule/Model/System/Config/Source/Coupon/Format.php | 2 -- app/code/Magento/SendFriend/Block/Send.php | 1 - app/code/Magento/SendFriend/Helper/Data.php | 2 -- .../SendFriend/Model/ResourceModel/SendFriend/Collection.php | 2 -- app/code/Magento/SendFriend/Model/SendFriend.php | 1 - app/code/Magento/SendFriend/Model/Source/Checktype.php | 2 -- app/code/Magento/Shipping/Block/Adminhtml/View.php | 1 - app/code/Magento/Shipping/Block/Adminhtml/View/Comments.php | 2 -- app/code/Magento/Shipping/Block/Adminhtml/View/Form.php | 2 -- app/code/Magento/Shipping/Block/Items.php | 2 -- app/code/Magento/Shipping/Model/Shipment/Request.php | 2 -- app/code/Magento/Shipping/Model/Shipment/ReturnShipment.php | 2 -- app/code/Magento/Sitemap/Block/Adminhtml/Edit.php | 2 -- app/code/Magento/Sitemap/Block/Adminhtml/Edit/Form.php | 2 -- app/code/Magento/Sitemap/Model/Observer.php | 2 -- .../Magento/Sitemap/Model/ResourceModel/Sitemap/Collection.php | 1 - 22 files changed, 40 deletions(-) diff --git a/app/code/Magento/SalesRule/Model/ResourceModel/Report/Rule/Updatedat.php b/app/code/Magento/SalesRule/Model/ResourceModel/Report/Rule/Updatedat.php index 2f599dd0d78ae..ed214171d5638 100644 --- a/app/code/Magento/SalesRule/Model/ResourceModel/Report/Rule/Updatedat.php +++ b/app/code/Magento/SalesRule/Model/ResourceModel/Report/Rule/Updatedat.php @@ -7,8 +7,6 @@ /** * Rule report resource model with aggregation by updated at - * - * @author Magento Core Team */ class Updatedat extends \Magento\SalesRule\Model\ResourceModel\Report\Rule\Createdat { diff --git a/app/code/Magento/SalesRule/Model/ResourceModel/Report/Updatedat/Collection.php b/app/code/Magento/SalesRule/Model/ResourceModel/Report/Updatedat/Collection.php index 0e408787beb7f..5902b63ce821c 100644 --- a/app/code/Magento/SalesRule/Model/ResourceModel/Report/Updatedat/Collection.php +++ b/app/code/Magento/SalesRule/Model/ResourceModel/Report/Updatedat/Collection.php @@ -7,8 +7,6 @@ /** * Sales report coupons collection - * - * @author Magento Core Team */ class Collection extends \Magento\SalesRule\Model\ResourceModel\Report\Collection { diff --git a/app/code/Magento/SalesRule/Model/ResourceModel/Rule/Customer.php b/app/code/Magento/SalesRule/Model/ResourceModel/Rule/Customer.php index 374c3fe505cdc..44e93d2d80ecb 100644 --- a/app/code/Magento/SalesRule/Model/ResourceModel/Rule/Customer.php +++ b/app/code/Magento/SalesRule/Model/ResourceModel/Rule/Customer.php @@ -7,8 +7,6 @@ /** * SalesRule Rule Customer Model Resource - * - * @author Magento Core Team */ class Customer extends \Magento\Framework\Model\ResourceModel\Db\AbstractDb { diff --git a/app/code/Magento/SalesRule/Model/ResourceModel/Rule/Customer/Collection.php b/app/code/Magento/SalesRule/Model/ResourceModel/Rule/Customer/Collection.php index d4b92110b955b..9bddea3a426cd 100644 --- a/app/code/Magento/SalesRule/Model/ResourceModel/Rule/Customer/Collection.php +++ b/app/code/Magento/SalesRule/Model/ResourceModel/Rule/Customer/Collection.php @@ -7,8 +7,6 @@ /** * SalesRule Model Resource Rule Customer_Collection - * - * @author Magento Core Team */ class Collection extends \Magento\Framework\Model\ResourceModel\Db\Collection\AbstractCollection { diff --git a/app/code/Magento/SalesRule/Model/Rule/Condition/Product.php b/app/code/Magento/SalesRule/Model/Rule/Condition/Product.php index cc65876fb513f..6bc8313458a0f 100644 --- a/app/code/Magento/SalesRule/Model/Rule/Condition/Product.php +++ b/app/code/Magento/SalesRule/Model/Rule/Condition/Product.php @@ -7,8 +7,6 @@ /** * Product rule condition data model - * - * @author Magento Core Team */ class Product extends \Magento\Rule\Model\Condition\Product\AbstractProduct { diff --git a/app/code/Magento/SalesRule/Model/Rule/Customer.php b/app/code/Magento/SalesRule/Model/Rule/Customer.php index 34f643aca5983..50700b287adbc 100644 --- a/app/code/Magento/SalesRule/Model/Rule/Customer.php +++ b/app/code/Magento/SalesRule/Model/Rule/Customer.php @@ -14,8 +14,6 @@ * @method \Magento\SalesRule\Model\Rule\Customer setCustomerId(int $value) * @method int getTimesUsed() * @method \Magento\SalesRule\Model\Rule\Customer setTimesUsed(int $value) - * - * @author Magento Core Team */ class Customer extends \Magento\Framework\Model\AbstractModel { diff --git a/app/code/Magento/SalesRule/Model/System/Config/Source/Coupon/Format.php b/app/code/Magento/SalesRule/Model/System/Config/Source/Coupon/Format.php index 04e9b525f5274..d28707e10988b 100644 --- a/app/code/Magento/SalesRule/Model/System/Config/Source/Coupon/Format.php +++ b/app/code/Magento/SalesRule/Model/System/Config/Source/Coupon/Format.php @@ -7,8 +7,6 @@ /** * Options for Code Format Field in Auto Generated Specific Coupon Codes configuration section - * - * @author Magento Core Team */ class Format implements \Magento\Framework\Option\ArrayInterface { diff --git a/app/code/Magento/SendFriend/Block/Send.php b/app/code/Magento/SendFriend/Block/Send.php index 6f2154ba29f47..b90479d5de184 100644 --- a/app/code/Magento/SendFriend/Block/Send.php +++ b/app/code/Magento/SendFriend/Block/Send.php @@ -12,7 +12,6 @@ * Email to a Friend Block * * @api - * @author Magento Core Team * @since 100.0.2 */ class Send extends \Magento\Framework\View\Element\Template diff --git a/app/code/Magento/SendFriend/Helper/Data.php b/app/code/Magento/SendFriend/Helper/Data.php index 7725ad605aea2..e195b5ad42ae3 100644 --- a/app/code/Magento/SendFriend/Helper/Data.php +++ b/app/code/Magento/SendFriend/Helper/Data.php @@ -9,8 +9,6 @@ /** * SendFriend Data Helper * - * @author Magento Core Team - * * @api * @since 100.0.2 */ diff --git a/app/code/Magento/SendFriend/Model/ResourceModel/SendFriend/Collection.php b/app/code/Magento/SendFriend/Model/ResourceModel/SendFriend/Collection.php index c06151deff9fd..36cc9564ea595 100644 --- a/app/code/Magento/SendFriend/Model/ResourceModel/SendFriend/Collection.php +++ b/app/code/Magento/SendFriend/Model/ResourceModel/SendFriend/Collection.php @@ -8,8 +8,6 @@ /** * SendFriend log resource collection * - * @author Magento Core Team - * * @api * @since 100.0.2 */ diff --git a/app/code/Magento/SendFriend/Model/SendFriend.php b/app/code/Magento/SendFriend/Model/SendFriend.php index d1dc34ec6dff9..d99d85de7906a 100644 --- a/app/code/Magento/SendFriend/Model/SendFriend.php +++ b/app/code/Magento/SendFriend/Model/SendFriend.php @@ -22,7 +22,6 @@ * @method int getTime() * @method \Magento\SendFriend\Model\SendFriend setTime(int $value) * - * @author Magento Core Team * @SuppressWarnings(PHPMD.CookieAndSessionMisuse) * @SuppressWarnings(PHPMD.CouplingBetweenObjects) * diff --git a/app/code/Magento/SendFriend/Model/Source/Checktype.php b/app/code/Magento/SendFriend/Model/Source/Checktype.php index 231e5944beb9a..78c098f2575bb 100644 --- a/app/code/Magento/SendFriend/Model/Source/Checktype.php +++ b/app/code/Magento/SendFriend/Model/Source/Checktype.php @@ -6,8 +6,6 @@ /** * Send to a Friend Limit sending by Source - * - * @author Magento Core Team */ namespace Magento\SendFriend\Model\Source; diff --git a/app/code/Magento/Shipping/Block/Adminhtml/View.php b/app/code/Magento/Shipping/Block/Adminhtml/View.php index 04df7f6e35e24..0c09b1e6a3067 100644 --- a/app/code/Magento/Shipping/Block/Adminhtml/View.php +++ b/app/code/Magento/Shipping/Block/Adminhtml/View.php @@ -9,7 +9,6 @@ * Adminhtml shipment create * * @api - * @author Magento Core Team * @since 100.0.2 */ class View extends \Magento\Backend\Block\Widget\Form\Container diff --git a/app/code/Magento/Shipping/Block/Adminhtml/View/Comments.php b/app/code/Magento/Shipping/Block/Adminhtml/View/Comments.php index 7c852d7ebbf71..0cfe6a0133a45 100644 --- a/app/code/Magento/Shipping/Block/Adminhtml/View/Comments.php +++ b/app/code/Magento/Shipping/Block/Adminhtml/View/Comments.php @@ -6,8 +6,6 @@ /** * Adminhtml sales shipment comment view block - * - * @author Magento Core Team */ namespace Magento\Shipping\Block\Adminhtml\View; diff --git a/app/code/Magento/Shipping/Block/Adminhtml/View/Form.php b/app/code/Magento/Shipping/Block/Adminhtml/View/Form.php index 8467a34ed0368..5f7e7ba864aac 100644 --- a/app/code/Magento/Shipping/Block/Adminhtml/View/Form.php +++ b/app/code/Magento/Shipping/Block/Adminhtml/View/Form.php @@ -6,8 +6,6 @@ /** * Shipment view form - * - * @author Magento Core Team */ namespace Magento\Shipping\Block\Adminhtml\View; diff --git a/app/code/Magento/Shipping/Block/Items.php b/app/code/Magento/Shipping/Block/Items.php index 59f92e8ea303d..689c0afb16fd2 100644 --- a/app/code/Magento/Shipping/Block/Items.php +++ b/app/code/Magento/Shipping/Block/Items.php @@ -6,8 +6,6 @@ /** * Sales order view items block - * - * @author Magento Core Team */ namespace Magento\Shipping\Block; diff --git a/app/code/Magento/Shipping/Model/Shipment/Request.php b/app/code/Magento/Shipping/Model/Shipment/Request.php index 23f7924dc0c3a..1ddc0078d0efc 100644 --- a/app/code/Magento/Shipping/Model/Shipment/Request.php +++ b/app/code/Magento/Shipping/Model/Shipment/Request.php @@ -60,8 +60,6 @@ * @method string getShippingMethod() * @method \Magento\Shipping\Model\Shipment\Request setPackageWeight(float $value) * @method float getPackageWeight() - * - * @author Magento Core Team */ class Request extends \Magento\Framework\DataObject { diff --git a/app/code/Magento/Shipping/Model/Shipment/ReturnShipment.php b/app/code/Magento/Shipping/Model/Shipment/ReturnShipment.php index 6a67c5b9c8f97..6ecd199ba9476 100644 --- a/app/code/Magento/Shipping/Model/Shipment/ReturnShipment.php +++ b/app/code/Magento/Shipping/Model/Shipment/ReturnShipment.php @@ -60,8 +60,6 @@ * @method string getShippingMethod() * @method \Magento\Shipping\Model\Shipment\Request setPackageWeight(float $value) * @method float getPackageWeight() - * - * @author Magento Core Team */ class ReturnShipment extends \Magento\Framework\DataObject { diff --git a/app/code/Magento/Sitemap/Block/Adminhtml/Edit.php b/app/code/Magento/Sitemap/Block/Adminhtml/Edit.php index d1b5fd1df45c4..a1f4e034d8a40 100644 --- a/app/code/Magento/Sitemap/Block/Adminhtml/Edit.php +++ b/app/code/Magento/Sitemap/Block/Adminhtml/Edit.php @@ -7,8 +7,6 @@ /** * Sitemap edit form container - * - * @author Magento Core Team */ class Edit extends \Magento\Backend\Block\Widget\Form\Container { diff --git a/app/code/Magento/Sitemap/Block/Adminhtml/Edit/Form.php b/app/code/Magento/Sitemap/Block/Adminhtml/Edit/Form.php index 267fa034337ab..4d8355d635aae 100644 --- a/app/code/Magento/Sitemap/Block/Adminhtml/Edit/Form.php +++ b/app/code/Magento/Sitemap/Block/Adminhtml/Edit/Form.php @@ -7,8 +7,6 @@ /** * Sitemap edit form - * - * @author Magento Core Team */ class Form extends \Magento\Backend\Block\Widget\Form\Generic { diff --git a/app/code/Magento/Sitemap/Model/Observer.php b/app/code/Magento/Sitemap/Model/Observer.php index 4333c71c7497f..3dd4fede004a9 100644 --- a/app/code/Magento/Sitemap/Model/Observer.php +++ b/app/code/Magento/Sitemap/Model/Observer.php @@ -16,8 +16,6 @@ /** * Sitemap module observer - * - * @author Magento Core Team */ class Observer { diff --git a/app/code/Magento/Sitemap/Model/ResourceModel/Sitemap/Collection.php b/app/code/Magento/Sitemap/Model/ResourceModel/Sitemap/Collection.php index 9b2128ffe3328..c1b138808974d 100644 --- a/app/code/Magento/Sitemap/Model/ResourceModel/Sitemap/Collection.php +++ b/app/code/Magento/Sitemap/Model/ResourceModel/Sitemap/Collection.php @@ -8,7 +8,6 @@ /** * Sitemap resource model collection * - * @author Magento Core Team * @api * @since 100.0.2 */ From 20973b577ef98600a30ac6f5255828ab73212899 Mon Sep 17 00:00:00 2001 From: engcom-Echo Date: Mon, 10 Jun 2024 11:01:25 +0530 Subject: [PATCH 2/5] Fixed static test failrues --- .../System/Config/Source/Coupon/Format.php | 4 +--- app/code/Magento/SendFriend/Block/Send.php | 5 +---- app/code/Magento/SendFriend/Helper/Data.php | 18 +++++++++--------- .../Magento/Shipping/Block/Adminhtml/View.php | 14 ++++++++++++-- .../Shipping/Block/Adminhtml/View/Comments.php | 2 -- app/code/Magento/Shipping/Block/Items.php | 2 -- .../Magento/Sitemap/Block/Adminhtml/Edit.php | 2 -- app/code/Magento/Sitemap/Model/Observer.php | 12 +++++------- 8 files changed, 28 insertions(+), 31 deletions(-) diff --git a/app/code/Magento/SalesRule/Model/System/Config/Source/Coupon/Format.php b/app/code/Magento/SalesRule/Model/System/Config/Source/Coupon/Format.php index d28707e10988b..43d7bd4be612d 100644 --- a/app/code/Magento/SalesRule/Model/System/Config/Source/Coupon/Format.php +++ b/app/code/Magento/SalesRule/Model/System/Config/Source/Coupon/Format.php @@ -11,8 +11,6 @@ class Format implements \Magento\Framework\Option\ArrayInterface { /** - * Sales rule coupon - * * @var \Magento\SalesRule\Helper\Coupon */ protected $_salesRuleCoupon = null; @@ -26,7 +24,7 @@ public function __construct(\Magento\SalesRule\Helper\Coupon $salesRuleCoupon) } /** - * {@inheritdoc} + * @inheritdoc */ public function toOptionArray() { diff --git a/app/code/Magento/SendFriend/Block/Send.php b/app/code/Magento/SendFriend/Block/Send.php index b90479d5de184..45aa6ab86805d 100644 --- a/app/code/Magento/SendFriend/Block/Send.php +++ b/app/code/Magento/SendFriend/Block/Send.php @@ -17,15 +17,11 @@ class Send extends \Magento\Framework\View\Element\Template { /** - * SendFriend data - * * @var \Magento\SendFriend\Helper\Data */ protected $_sendfriendData = null; /** - * Core registry - * * @var \Magento\Framework\Registry */ protected $_coreRegistry = null; @@ -227,6 +223,7 @@ public function canSend() /** * @inheritdoc + * @return void * @since 100.3.1 */ protected function _prepareLayout() diff --git a/app/code/Magento/SendFriend/Helper/Data.php b/app/code/Magento/SendFriend/Helper/Data.php index e195b5ad42ae3..4776afc713f4d 100644 --- a/app/code/Magento/SendFriend/Helper/Data.php +++ b/app/code/Magento/SendFriend/Helper/Data.php @@ -14,23 +14,23 @@ */ class Data extends \Magento\Framework\App\Helper\AbstractHelper { - const XML_PATH_ENABLED = 'sendfriend/email/enabled'; + public const XML_PATH_ENABLED = 'sendfriend/email/enabled'; - const XML_PATH_ALLOW_FOR_GUEST = 'sendfriend/email/allow_guest'; + public const XML_PATH_ALLOW_FOR_GUEST = 'sendfriend/email/allow_guest'; - const XML_PATH_MAX_RECIPIENTS = 'sendfriend/email/max_recipients'; + public const XML_PATH_MAX_RECIPIENTS = 'sendfriend/email/max_recipients'; - const XML_PATH_MAX_PER_HOUR = 'sendfriend/email/max_per_hour'; + public const XML_PATH_MAX_PER_HOUR = 'sendfriend/email/max_per_hour'; - const XML_PATH_LIMIT_BY = 'sendfriend/email/check_by'; + public const XML_PATH_LIMIT_BY = 'sendfriend/email/check_by'; - const XML_PATH_EMAIL_TEMPLATE = 'sendfriend/email/template'; + public const XML_PATH_EMAIL_TEMPLATE = 'sendfriend/email/template'; - const COOKIE_NAME = 'stf'; + public const COOKIE_NAME = 'stf'; - const CHECK_IP = 1; + public const CHECK_IP = 1; - const CHECK_COOKIE = 0; + public const CHECK_COOKIE = 0; /** * Check is enabled Module diff --git a/app/code/Magento/Shipping/Block/Adminhtml/View.php b/app/code/Magento/Shipping/Block/Adminhtml/View.php index 0c09b1e6a3067..bc53c0f87c100 100644 --- a/app/code/Magento/Shipping/Block/Adminhtml/View.php +++ b/app/code/Magento/Shipping/Block/Adminhtml/View.php @@ -14,8 +14,6 @@ class View extends \Magento\Backend\Block\Widget\Form\Container { /** - * Core registry - * * @var \Magento\Framework\Registry */ protected $_coreRegistry = null; @@ -35,6 +33,8 @@ public function __construct( } /** + * Initialize View + * * @return void */ protected function _construct() @@ -84,6 +84,8 @@ public function getShipment() } /** + * Header Text get + * * @return \Magento\Framework\Phrase */ public function getHeaderText() @@ -106,6 +108,8 @@ public function getHeaderText() } /** + * Get URL + * * @return string */ public function getBackUrl() @@ -120,6 +124,8 @@ public function getBackUrl() } /** + * Get Email Url + * * @return string */ public function getEmailUrl() @@ -128,6 +134,8 @@ public function getEmailUrl() } /** + * Get Print Url + * * @return string */ public function getPrintUrl() @@ -136,6 +144,8 @@ public function getPrintUrl() } /** + * Update back button url + * * @param bool $flag * @return $this */ diff --git a/app/code/Magento/Shipping/Block/Adminhtml/View/Comments.php b/app/code/Magento/Shipping/Block/Adminhtml/View/Comments.php index 0cfe6a0133a45..ce71a17dab223 100644 --- a/app/code/Magento/Shipping/Block/Adminhtml/View/Comments.php +++ b/app/code/Magento/Shipping/Block/Adminhtml/View/Comments.php @@ -16,8 +16,6 @@ class Comments extends \Magento\Backend\Block\Text\ListText { /** - * Core registry - * * @var \Magento\Framework\Registry */ protected $_coreRegistry = null; diff --git a/app/code/Magento/Shipping/Block/Items.php b/app/code/Magento/Shipping/Block/Items.php index 689c0afb16fd2..d1d011328eb24 100644 --- a/app/code/Magento/Shipping/Block/Items.php +++ b/app/code/Magento/Shipping/Block/Items.php @@ -18,8 +18,6 @@ class Items extends \Magento\Sales\Block\Items\AbstractItems { /** - * Core registry - * * @var \Magento\Framework\Registry */ protected $_coreRegistry = null; diff --git a/app/code/Magento/Sitemap/Block/Adminhtml/Edit.php b/app/code/Magento/Sitemap/Block/Adminhtml/Edit.php index a1f4e034d8a40..91bb648b641bb 100644 --- a/app/code/Magento/Sitemap/Block/Adminhtml/Edit.php +++ b/app/code/Magento/Sitemap/Block/Adminhtml/Edit.php @@ -11,8 +11,6 @@ class Edit extends \Magento\Backend\Block\Widget\Form\Container { /** - * Core registry - * * @var \Magento\Framework\Registry */ protected $_coreRegistry = null; diff --git a/app/code/Magento/Sitemap/Model/Observer.php b/app/code/Magento/Sitemap/Model/Observer.php index 3dd4fede004a9..7f8f04b5b0417 100644 --- a/app/code/Magento/Sitemap/Model/Observer.php +++ b/app/code/Magento/Sitemap/Model/Observer.php @@ -22,33 +22,31 @@ class Observer /** * Enable/disable configuration */ - const XML_PATH_GENERATION_ENABLED = 'sitemap/generate/enabled'; + public const XML_PATH_GENERATION_ENABLED = 'sitemap/generate/enabled'; /** * Cronjob expression configuration * * @deprecated Use \Magento\Cron\Model\Config\Backend\Sitemap::CRON_STRING_PATH instead. */ - const XML_PATH_CRON_EXPR = 'crontab/default/jobs/generate_sitemaps/schedule/cron_expr'; + public const XML_PATH_CRON_EXPR = 'crontab/default/jobs/generate_sitemaps/schedule/cron_expr'; /** * Error email template configuration */ - const XML_PATH_ERROR_TEMPLATE = 'sitemap/generate/error_email_template'; + public const XML_PATH_ERROR_TEMPLATE = 'sitemap/generate/error_email_template'; /** * Error email identity configuration */ - const XML_PATH_ERROR_IDENTITY = 'sitemap/generate/error_email_identity'; + public const XML_PATH_ERROR_IDENTITY = 'sitemap/generate/error_email_identity'; /** * 'Send error emails to' configuration */ - const XML_PATH_ERROR_RECIPIENT = 'sitemap/generate/error_email'; + public const XML_PATH_ERROR_RECIPIENT = 'sitemap/generate/error_email'; /** - * Core store config - * * @var \Magento\Framework\App\Config\ScopeConfigInterface */ private $scopeConfig; From cede72708d7c90ecc0480ad8eeaadd27498718d0 Mon Sep 17 00:00:00 2001 From: Anupam Bhatt <51681435+engcom-Echo@users.noreply.github.com> Date: Mon, 10 Jun 2024 12:41:15 +0530 Subject: [PATCH 3/5] Fixed SVC failure --- app/code/Magento/SendFriend/Block/Send.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/SendFriend/Block/Send.php b/app/code/Magento/SendFriend/Block/Send.php index 45aa6ab86805d..adeba99a2a07c 100644 --- a/app/code/Magento/SendFriend/Block/Send.php +++ b/app/code/Magento/SendFriend/Block/Send.php @@ -223,8 +223,8 @@ public function canSend() /** * @inheritdoc - * @return void * @since 100.3.1 + * @codeCoverageIgnore */ protected function _prepareLayout() { From 6afbaaa9e4c005ccc36462967749a65c88d631b0 Mon Sep 17 00:00:00 2001 From: Anupam Bhatt <51681435+engcom-Echo@users.noreply.github.com> Date: Tue, 11 Jun 2024 12:07:42 +0530 Subject: [PATCH 4/5] Fix Static Test --- app/code/Magento/SendFriend/Block/Send.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/SendFriend/Block/Send.php b/app/code/Magento/SendFriend/Block/Send.php index adeba99a2a07c..ea3bfaf586432 100644 --- a/app/code/Magento/SendFriend/Block/Send.php +++ b/app/code/Magento/SendFriend/Block/Send.php @@ -224,7 +224,7 @@ public function canSend() /** * @inheritdoc * @since 100.3.1 - * @codeCoverageIgnore + * phpcs:disable */ protected function _prepareLayout() { From c9dfb9517aff560dc62fa151e3d6d9d440e603c3 Mon Sep 17 00:00:00 2001 From: Anupam Bhatt <51681435+engcom-Echo@users.noreply.github.com> Date: Thu, 11 Jul 2024 12:25:21 +0530 Subject: [PATCH 5/5] Fixed static test failures --- app/code/Magento/SendFriend/Block/Send.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/SendFriend/Block/Send.php b/app/code/Magento/SendFriend/Block/Send.php index ea3bfaf586432..a2bc2f49d32ee 100644 --- a/app/code/Magento/SendFriend/Block/Send.php +++ b/app/code/Magento/SendFriend/Block/Send.php @@ -224,7 +224,7 @@ public function canSend() /** * @inheritdoc * @since 100.3.1 - * phpcs:disable + * phpstan:ignore */ protected function _prepareLayout() {