From 52bd67e5ec4029132d1052d54df66d0e3d4dff14 Mon Sep 17 00:00:00 2001
From: Kiel Pykett <pykettk@gmail.com>
Date: Thu, 9 Mar 2023 00:59:25 +0000
Subject: [PATCH] Chore: Store - Replace Block Escaping with Escaper

---
 .../frontend/templates/switch/flags.phtml     | 10 +++++---
 .../frontend/templates/switch/languages.phtml | 23 +++++++++++--------
 .../frontend/templates/switch/stores.phtml    | 13 +++++++----
 3 files changed, 30 insertions(+), 16 deletions(-)

diff --git a/app/code/Magento/Store/view/frontend/templates/switch/flags.phtml b/app/code/Magento/Store/view/frontend/templates/switch/flags.phtml
index 9c48469e9d560..5bee7c40bcfd0 100644
--- a/app/code/Magento/Store/view/frontend/templates/switch/flags.phtml
+++ b/app/code/Magento/Store/view/frontend/templates/switch/flags.phtml
@@ -3,16 +3,20 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
+use Magento\Framework\Escaper;
+
+/** @var Escaper $escaper */
 // @deprecated
 ?>
 <?php if (count($block->getStores())>1) : ?>
 <div class="form-language">
-    <label for="select-language"><?= $block->escapeHtml(__('Your Language:')) ?></label>
-    <select id="select-language" title="<?= $block->escapeHtmlAttr(__('Your Language')) ?>" onchange="window.location.href=this.value" class="flags">
+    <label for="select-language"><?= $escaper->escapeHtml(__('Your Language:')) ?></label>
+    <select id="select-language" title="<?= $escaper->escapeHtmlAttr(__('Your Language')) ?>" onchange="window.location.href=this.value" class="flags">
     <?php foreach ($block->getStores() as $_lang) : ?>
         <?php $_selected = ($_lang->getId() == $block->getCurrentStoreId()) ? ' selected="selected"' : '' ?>
-        <option value="<?= $block->escapeUrl($_lang->getCurrentUrl()) ?>" style="background-image:url('<?= $block->escapeUrl($block->getViewFileUrl('images/flags/flag_' . $_lang->getCode() . '.gif')) ?>');"<?= /* @noEscape */ $_selected ?>><?= $block->escapeHtml($_lang->getName()) ?></option>
+        <option value="<?= $escaper->escapeUrl($_lang->getCurrentUrl()) ?>" style="background-image:url('<?= $escaper->escapeUrl($block->getViewFileUrl('images/flags/flag_' . $_lang->getCode() . '.gif')) ?>');"<?= /* @noEscape */ $_selected ?>><?= $escaper->escapeHtml($_lang->getName()) ?></option>
     <?php endforeach; ?>
     </select>
 </div>
diff --git a/app/code/Magento/Store/view/frontend/templates/switch/languages.phtml b/app/code/Magento/Store/view/frontend/templates/switch/languages.phtml
index 87a2c40fddaa1..39762e130900e 100644
--- a/app/code/Magento/Store/view/frontend/templates/switch/languages.phtml
+++ b/app/code/Magento/Store/view/frontend/templates/switch/languages.phtml
@@ -3,30 +3,35 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
-/** @var \Magento\Store\Block\Switcher $block */
+use Magento\Framework\Escaper;
+use Magento\Store\Block\Switcher;
+
+/** @var Escaper $escaper */
+/** @var Switcher $block */
 ?>
 <?php if (count($block->getStores())>1) : ?>
     <?php $id = $block->getIdModifier() ? '-' . $block->getIdModifier() : '' ?>
-    <div class="switcher language switcher-language" data-ui-id="language-switcher" id="switcher-language<?= $block->escapeHtmlAttr($id) ?>">
-        <strong class="label switcher-label"><span><?= $block->escapeHtml(__('Language')) ?></span></strong>
+    <div class="switcher language switcher-language" data-ui-id="language-switcher" id="switcher-language<?= $escaper->escapeHtmlAttr($id) ?>">
+        <strong class="label switcher-label"><span><?= $escaper->escapeHtml(__('Language')) ?></span></strong>
         <div class="actions dropdown options switcher-options">
             <div class="action toggle switcher-trigger"
-                 id="switcher-language-trigger<?= $block->escapeHtmlAttr($id) ?>"
+                 id="switcher-language-trigger<?= $escaper->escapeHtmlAttr($id) ?>"
                  data-mage-init='{"dropdown":{}}'
                  data-toggle="dropdown"
                  data-trigger-keypress-button="true">
-                <strong class="view-<?= $block->escapeHtml($block->getCurrentStoreCode()) ?>">
-                    <span><?= $block->escapeHtml($block->getStoreName()) ?></span>
+                <strong class="view-<?= $escaper->escapeHtml($block->getCurrentStoreCode()) ?>">
+                    <span><?= $escaper->escapeHtml($block->getStoreName()) ?></span>
                 </strong>
             </div>
             <ul class="dropdown switcher-dropdown"
                 data-target="dropdown">
                 <?php foreach ($block->getStores() as $_lang) : ?>
                     <?php if ($_lang->getId() != $block->getCurrentStoreId()) : ?>
-                        <li class="view-<?= $block->escapeHtml($_lang->getCode()) ?> switcher-option">
-                            <a href="<?= $block->escapeUrl($block->getViewModel()->getTargetStoreRedirectUrl($_lang)) ?>">
-                                <?= $block->escapeHtml($_lang->getName()) ?>
+                        <li class="view-<?= $escaper->escapeHtml($_lang->getCode()) ?> switcher-option">
+                            <a href="<?= $escaper->escapeUrl($block->getViewModel()->getTargetStoreRedirectUrl($_lang)) ?>">
+                                <?= $escaper->escapeHtml($_lang->getName()) ?>
                             </a>
                         </li>
                     <?php endif; ?>
diff --git a/app/code/Magento/Store/view/frontend/templates/switch/stores.phtml b/app/code/Magento/Store/view/frontend/templates/switch/stores.phtml
index e0c49401a6ce5..402c857f41da8 100644
--- a/app/code/Magento/Store/view/frontend/templates/switch/stores.phtml
+++ b/app/code/Magento/Store/view/frontend/templates/switch/stores.phtml
@@ -3,12 +3,17 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
-/** @var \Magento\Store\Block\Switcher $block */
+use Magento\Framework\Escaper;
+use Magento\Store\Block\Switcher;
+
+/** @var Escaper $escaper */
+/** @var Switcher $block */
 ?>
 <?php if (count($block->getGroups())>1) : ?>
 <div class="switcher store switcher-store" id="switcher-store">
-    <strong class="label switcher-label"><span><?= $block->escapeHtml(__('Select Store')) ?></span></strong>
+    <strong class="label switcher-label"><span><?= $escaper->escapeHtml(__('Select Store')) ?></span></strong>
     <div class="actions dropdown options switcher-options">
         <?php foreach ($block->getGroups() as $_group) : ?>
             <?php if ($_group->getId() == $block->getCurrentGroupId()) : ?>
@@ -20,7 +25,7 @@
                      data-trigger-keypress-button="true"
                      id="switcher-store-trigger">
                     <strong>
-                        <span><?= $block->escapeHtml($_group->getName()) ?></span>
+                        <span><?= $escaper->escapeHtml($_group->getName()) ?></span>
                     </strong>
                 </div>
             <?php endif; ?>
@@ -30,7 +35,7 @@
                 <?php if (!($_group->getId() == $block->getCurrentGroupId())) : ?>
                     <li class="switcher-option">
                         <a href="#" data-post='<?= /* @noEscape */ $block->getTargetStorePostData($_group->getDefaultStore()) ?>'>
-                            <?= $block->escapeHtml($_group->getName()) ?>
+                            <?= $escaper->escapeHtml($_group->getName()) ?>
                         </a>
                     </li>
                 <?php endif; ?>