Skip to content

Commit 35e9135

Browse files
authored
Merge pull request #4 from mattdeform/updates-to-ci-and-contributing
pre-release update
2 parents 7345b24 + f0e7016 commit 35e9135

File tree

6 files changed

+17
-19
lines changed

6 files changed

+17
-19
lines changed

.github/workflows/ci-release.yml

+2-3
Original file line numberDiff line numberDiff line change
@@ -10,21 +10,20 @@ jobs:
1010
uses: ./.github/workflows/reusable-static-analysis.yml
1111

1212
tests:
13-
needs: static-analysis
1413
if: github.repository != 'mattdeform/MayaPythonProjectTemplate'
1514
uses: ./.github/workflows/reusable-maya-tests.yml
1615

1716
do_release:
1817
if: github.repository != 'mattdeform/MayaPythonProjectTemplate'
19-
needs: [static-analysis, tests]
18+
needs: [tests]
2019
uses: ./.github/workflows/reusable-semantic-release.yml
2120
permissions:
2221
contents: write
2322
id-token: write
2423

2524
docs:
2625
if: github.repository != 'mattdeform/MayaPythonProjectTemplate'
27-
needs: [static-analysis, tests, do_release] # only build docs when release is successful
26+
needs: [tests, do_release] # only build docs when release is successful
2827
uses: ./.github/workflows/reusable-build-and-deploy-docs.yml
2928
permissions:
3029
contents: write

.github/workflows/reusable-static-analysis.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
- name: Install dependencies
2727
run: |
2828
python -m pip install --upgrade pip
29-
pip install pylint black mypy
29+
pip install pylint mypy
3030
3131
- name: Analysing the code with pylint
3232
run: |
@@ -36,7 +36,7 @@ jobs:
3636
uses: psf/black@stable
3737
with:
3838
src: "src"
39-
options: "--check"
39+
options: "--diff"
4040

4141
- name: Analysing the code with mypy
4242
run: mypy src

CONTRIBUTING.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,12 @@ This project (optionally) uses [Python Semantic Release](https://python-semantic
5151

5252
Cheat sheet:
5353

54-
- Patch release, backwards-compatible bug `fix` _in git commit message title_, e.g.
55-
- `git commit -m 'fix: a great fix'`
54+
- Patch release, backwards-compatible bug `fix` _in git commit message title_.
55+
- `git commit -a -m "fix: a great fix"`
5656
- Minor release, backwards-compatible `feat` _in git commit message title_.
57-
- `git commit -m 'feat: Add some AmazingFeature'`
58-
- Major release, incompatible API change `BREAKING CHANGE` _in git commit msg footer (use `fix` or `feat` for message title)_.
59-
- `git commit -m 'feat: Add some AmazingFeature\n\nBREAKING CHANGE'`
57+
- `git commit -a -m "feat: a wonderful new feature"`
58+
- Major release, incompatible API change `BREAKING CHANGE` _in git commit message footer (use `fix` or `feat` for message title)_.
59+
- `git commit -a -m "feat: total refactor" -m "BREAKING CHANGE: breaks api"`
6060

6161

6262
<p align="right">(<a href="#readme-top">back to top</a>)</p>

README.md

+7-8
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,14 @@
1616
<h3 align="center">Maya Python Project Template</h3>
1717

1818
<p align="center">
19-
A GitHub template for Maya Python tools.
20-
<br />
19+
A GitHub template for Maya Python tools by <a href="https://www.techartops.com">TechArtOps</a>.<br>
2120
<a href="https://github.com/mattdeform/MayaPythonProjectTemplate/issues/new?labels=bug&template=bug-report---.md">Report Bug</a>
2221
·
2322
<a href="https://github.com/mattdeform/MayaPythonProjectTemplate/issues/new?labels=enhancement&template=feature-request---.md">Request Feature</a>
2423
</p>
2524
</div>
2625

27-
26+
> Example project built using this template can be found [here](https://github.com/mattdeform/locator_creator).
2827
2928
## HOW TO USE THIS TEMPLATE
3029

@@ -39,20 +38,20 @@
3938
4039
## What is included in this template?
4140
* Basic project structure.
42-
* [README.md](_README.md) template.
43-
* [CONTRIBUTING.md](CONTRIBUTING.md) template.
41+
* [README.md](_README) and [CONTRIBUTING](CONTRIBUTING.md) templates.
4442
* Bug report and feature request templates.
4543
* Continuous integration using [GitHub Actions][github-actions-url] with jobs to:
46-
* [Run tests](.github/workflows/reusable-maya-tests.yml) in containerized Maya. `Note: User should hold a valid Maya license.`
44+
* [Run integration tests](.github/workflows/reusable-maya-tests.yml) across a range of Maya versions in isolated Docker containers.
45+
* `Note: You should hold a valid Maya license.`
4746
* [Enforce coding standards](.github/workflows/reusable-static-analysis.yml) with [pylint](https://pypi.org/project/pylint/), [black](https://github.com/psf/black), and [mypy](https://mypy.readthedocs.io/en/stable/).
4847
* [Build and deploy documentation](.github/workflows/reusable-build-and-deploy-docs.yml) to GitHub pages with [mkdocs](https://www.mkdocs.org/).
49-
* [Make versioned releases](.github/workflows/ci-release.yml) using python semantic versioning.
48+
* [Automated releases](.github/workflows/ci-release.yml) using Python Semantic Versioning (optional).
5049

5150

5251
<!-- ACKNOWLEDGMENTS -->
5352
## Acknowledgments
5453
* This project uses Docker images courtesy of [mottosso/docker-maya](https://github.com/mottosso/docker-maya).
55-
* Inspiration taken from both
54+
* Inspiration taken from both:
5655
* [python-project-template](https://github.com/rochacbruno/python-project-template/tree/main).
5756
* [Best-README-Template](https://github.com/othneildrew/Best-README-Template).
5857

_README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -154,9 +154,9 @@ Please reach out via the [request a feature](https://github.com/{{PROJECT_OWNER}
154154

155155
<!-- ACKNOWLEDGMENTS -->
156156
## Acknowledgments
157+
* Project template by [TechArtOps](https://www.techartops.com).
157158
* foo
158159
* bar
159-
* baz
160160

161161
<p align="right">(<a href="#readme-top">back to top</a>)</p>
162162

docs/resources/images/ci_release.png

-10.2 KB
Loading

0 commit comments

Comments
 (0)