Skip to content

Commit e9d6e6c

Browse files
ro100eflanakin
andauthored
FinOps alerts fix for deployment bug (#1511)
Co-authored-by: Michael Flanakin <flanakin@users.noreply.github.com>
1 parent c01c835 commit e9d6e6c

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

Diff for: docs-mslearn/toolkit/changelog.md

+11-5
Original file line numberDiff line numberDiff line change
@@ -41,17 +41,23 @@ The following section lists features and enhancements that are currently in deve
4141
**Fixed**
4242
- Workaround subnets reordering and bicep limitation
4343

44-
### [Optimization engine](optimization-engine/overview.md)
45-
46-
- **Fixed**
47-
- Fixed issue with `Remediate-LongDeallocatedVMsFiltered` runbook that was skipping the remediation of eligible VMs due to `Az.Compute` module breaking changes ([#1456](https://github.com/microsoft/finops-toolkit/issues/1456)).
48-
4944
<br><a name="latest"></a>
5045

5146
## v0.10
5247

5348
_Released April 2025_
5449

50+
### [FinOps alerts](alerts/finops-alerts-overview.md) pending updates
51+
52+
- **Fixed**
53+
- Update the 'id' property for the managedApi to a valid scope
54+
- This caused a deployment error because the path could not be deserialized.
55+
56+
### [Optimization engine](optimization-engine/overview.md)
57+
58+
- **Fixed**
59+
- Fixed issue with `Remediate-LongDeallocatedVMsFiltered` runbook that was skipping the remediation of eligible VMs due to `Az.Compute` module breaking changes ([#1456](https://github.com/microsoft/finops-toolkit/issues/1456)).
60+
5561
> [!div class="nextstepaction"]
5662
> [Download](https://github.com/microsoft/finops-toolkit/releases/tag/v0.10)
5763
> [!div class="nextstepaction"]

Diff for: src/templates/finops-alerts/modules/logicApp.bicep

+3-3
Original file line numberDiff line numberDiff line change
@@ -3729,7 +3729,7 @@ resource finopsAlerts 'Microsoft.Logic/workflows@2019-05-01' = {
37293729
{
37303730
name: 'resourcesTable'
37313731
type: 'string'
3732-
value: 'resources@{if(equals(length(variables(\'IncludedSubscriptions\')), 0), \'\', concat(\'| where subscriptionId in ("\', replace(replace(string(variables(\'IncludedSubscriptions\')), \'[\', \'\'), \']\', \'\'), \'")\'))}@{if(equals(length(variables(\'ExcludedSubscriptions\')), 0), \'\', concat(\'| where subscriptionId !in ("\', replace(replace(string(variables(\'ExcludedSubscriptions\')), \'[\', \'\'), \']\', \'\'), \'")\'))}'
3732+
value: 'resources@{if(equals(length(variables(\'IncludedSubscriptions\')), 0), \'\', concat(\'| where subscriptionId in ("\', replace(replace(replace(string(variables(\'IncludedSubscriptions\')), \'\\n\', \'\'), \'[\', \'\'), \']\', \'\'), \'")\'))}@{if(equals(length(variables(\'ExcludedSubscriptions\')), 0), \'\', concat(\'| where subscriptionId !in ("\', replace(replace(replace(string(variables(\'ExcludedSubscriptions\')), \'\\n\', \'\'), \'[\', \'\'), \']\', \'\'), \'")\'))}'
37333733
}
37343734
]
37353735
}
@@ -4183,7 +4183,7 @@ resource finopsAlerts 'Microsoft.Logic/workflows@2019-05-01' = {
41834183
office365: {
41844184
connectionId: apiConnection.id
41854185
connectionName: connectionName
4186-
id: resourceId('Microsoft.Web/locations/managedApis', location, 'office365')
4186+
id: subscriptionResourceId('Microsoft.Web/locations/managedApis', location, 'office365')
41874187
}
41884188
}
41894189
}
@@ -4201,7 +4201,7 @@ resource apiConnection 'Microsoft.Web/connections@2016-06-01' = {
42014201
location: location
42024202
properties: {
42034203
api: {
4204-
id: resourceId('Microsoft.Web/locations/managedApis', location, 'office365')
4204+
id: subscriptionResourceId('Microsoft.Web/locations/managedApis', location, 'office365')
42054205
}
42064206
displayName:displayName
42074207
}

0 commit comments

Comments
 (0)