[Hub apps] Create the hub-storage module for storage setup (#1492)

Author: flanakin

Diff for: docs-mslearn/toolkit/changelog.md

@@ -34,6 +34,7 @@ The following section lists features and enhancements that are currently in deve
   - Added documentation for the [Add-FinOpsServicePrincipal PowerShell command](powershell/hubs/Add-FinOpsServicePrincipal.md).
   - Created a new bicep modules to support extensibility:
     - The **hub-app** module tracks telemetry when an app is deployed.
+    - The **hub-storage** module creates containers in the hub storage account.
 
 **Fixed**
   - Workaround subnets reordering and bicep limitation

Diff for: src/templates/finops-hub/modules/hub-storage.bicep

@@ -0,0 +1,43 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+//==============================================================================
+// Parameters
+//==============================================================================
+
+@description('Required. Name of the publisher-specific storage account to create or update.')
+param storageAccountName string
+
+@description('Required. Name of the storage container to create or update.')
+param container string
+
+
+//==============================================================================
+// Resources
+//==============================================================================
+
+// Get storage account instance
+resource storageAccount 'Microsoft.Storage/storageAccounts@2022-09-01' existing = {
+  name: storageAccountName
+  
+  resource blobService 'blobServices@2022-09-01' = {
+    name: 'default'
+
+    resource configContainer 'containers@2022-09-01' = {
+      name: container
+      properties: {
+        publicAccess: 'None'
+        metadata: {}
+      }
+    }
+  }
+}
+
+// TODO: Upload files
+// TODO: Enforce retention
+
+//==============================================================================
+// Outputs
+//==============================================================================
+
+output containerName string = storageAccount::blobService::configContainer.name

Diff for: src/templates/finops-hub/modules/storage.bicep

@@ -96,6 +96,7 @@ var blobUploadRbacRoles = [
 // Resources
 //==============================================================================
 
+// TODO: Move storage account creation to the hub-app module + output SA name
 resource storageAccount 'Microsoft.Storage/storageAccounts@2022-09-01' = {
   name: storageAccountName
   location: location
@@ -346,30 +347,27 @@ resource blobService 'Microsoft.Storage/storageAccounts/blobServices@2022-09-01'
   name: 'default'
 }
 
-resource configContainer 'Microsoft.Storage/storageAccounts/blobServices/containers@2022-09-01' = {
-  parent: blobService
-  name: 'config'
-  properties: {
-    publicAccess: 'None'
-    metadata: {}
+module configContainer 'hub-storage.bicep' = {
+  name: 'configContainer'
+  params: {
+    storageAccountName: storageAccount.name
+    container: 'config'
   }
 }
 
-resource exportContainer 'Microsoft.Storage/storageAccounts/blobServices/containers@2022-09-01' = {
-  parent: blobService
-  name: 'msexports'
-  properties: {
-    publicAccess: 'None'
-    metadata: {}
+module exportContainer 'hub-storage.bicep' = {
+  name: 'exportContainer'
+  params: {
+    storageAccountName: storageAccount.name
+    container: 'msexports'
   }
 }
 
-resource ingestionContainer 'Microsoft.Storage/storageAccounts/blobServices/containers@2022-09-01' = {
-  parent: blobService
-  name: 'ingestion'
-  properties: {
-    publicAccess: 'None'
-    metadata: {}
+module ingestionContainer 'hub-storage.bicep' = {
+  name: 'ingestionContainer'
+  params: {
+    storageAccountName: storageAccount.name
+    container: 'ingestion'
   }
 }
 
@@ -491,10 +489,10 @@ output scriptStorageAccountResourceId string = scriptStorageAccount.id
 output scriptStorageAccountName string = scriptStorageAccount.name
 
 @description('The name of the container used for configuration settings.')
-output configContainer string = configContainer.name
+output configContainer string = configContainer.outputs.containerName
 
 @description('The name of the container used for Cost Management exports.')
-output exportContainer string = exportContainer.name
+output exportContainer string = exportContainer.outputs.containerName
 
 @description('The name of the container used for normalized data ingestion.')
-output ingestionContainer string = ingestionContainer.name
+output ingestionContainer string = ingestionContainer.outputs.containerName