Remove Remoting V1 (#399)

- Remove obsolete types and members implementing Remoting V1
- Bump major version from 8 to 9 to reflect the breaking changes

Author: olegsych

Diff for: properties/service_fabric_common.props

@@ -22,9 +22,9 @@
 
     <!-- Version for binaries, nuget packages generated from this repo. -->
     <!-- TODO: Versions numbers are changed here manually for now, Integrate this with GitVersion. -->
-    <MajorVersion>8</MajorVersion>
+    <MajorVersion>9</MajorVersion>
     <MinorVersion>0</MinorVersion>
-    <BuildVersion>13</BuildVersion>
+    <BuildVersion>0</BuildVersion>
     <Revision>0</Revision>
 
   </PropertyGroup>

Diff for: src/FabActUtil/Generator/ManifestGenerator.cs

@@ -3,21 +3,21 @@
 // Licensed under the MIT License (MIT). See License.txt in the repo root for license information.
 // ------------------------------------------------------------
 
+using System;
+using System.Collections.Generic;
+using System.Fabric.Management.ServiceModel;
+using System.Globalization;
+using System.IO;
+using System.Linq;
+using System.Reflection;
+using System.Xml;
+using Microsoft.ServiceFabric.Actors.Generator;
+using Microsoft.ServiceFabric.Actors.Runtime;
+using Microsoft.ServiceFabric.Services.Remoting;
+using StartupServicesModel;
+
 namespace FabActUtil.Generator
 {
-    using System;
-    using System.Collections.Generic;
-    using System.Fabric.Management.ServiceModel;
-    using System.Globalization;
-    using System.IO;
-    using System.Linq;
-    using System.Reflection;
-    using System.Xml;
-    using Microsoft.ServiceFabric.Actors.Generator;
-    using Microsoft.ServiceFabric.Actors.Runtime;
-    using Microsoft.ServiceFabric.Services.Remoting;
-    using StartupServicesModel;
-
     /// <summary>
     /// ServiceManifestEntryPointType decides which kind of service manifest exe host is generated. By default the existing behavior of serviceName.exe will be used.
     /// </summary>
@@ -560,14 +560,7 @@ private static ServiceTypeType CreateServiceTypeType(
         private static Dictionary<string, Func<ActorTypeInformation, string>> GetGeneratedNameFunctionForServiceEndpoint(ActorTypeInformation actorTypeInfo)
         {
             var generatedNameFunctions = new Dictionary<string, Func<ActorTypeInformation, string>>();
-#if !DotNetCoreClr
-#pragma warning disable 618
-            if (Helper.IsRemotingV1(actorTypeInfo.RemotingListenerVersion))
-            {
-                generatedNameFunctions.Add(GeneratedServiceEndpointName, GetFabricServiceEndpointName);
-            }
-#pragma warning restore 618
-#endif
+
             if (Helper.IsRemotingV2(actorTypeInfo.RemotingListenerVersion))
             {
                 generatedNameFunctions.Add(GeneratedServiceEndpointV2Name, GetFabricServiceV2EndpointName);
@@ -584,18 +577,7 @@ private static Dictionary<string, Func<ActorTypeInformation, string>> GetGenerat
         private static List<EndpointType> CreateEndpointResourceBasedOnRemotingServer(ActorTypeInformation actorTypeInfo)
         {
             var endpoints = new List<EndpointType>();
-#if !DotNetCoreClr
-#pragma warning disable 618
-            if (Helper.IsRemotingV1(actorTypeInfo.RemotingListenerVersion))
-            {
-                endpoints.Add(
-                    new EndpointType()
-                    {
-                        Name = GetFabricServiceEndpointName(actorTypeInfo),
-                    });
-            }
-#pragma warning restore 618
-#endif
+
             if (Helper.IsRemotingV2(actorTypeInfo.RemotingListenerVersion))
             {
                 endpoints.Add(

Diff for: src/Microsoft.ServiceFabric.Actors.Wcf/Remoting/V1/Wcf/Client/WcfActorRemotingClientFactory.cs

@@ -3,17 +3,17 @@
 // Licensed under the MIT License (MIT). See License.txt in the repo root for license information.
 // ------------------------------------------------------------
 
+using System;
+using System.Collections.Generic;
+using Microsoft.ServiceFabric.Actors.Client;
+using Microsoft.ServiceFabric.Actors.Remoting.V2.Wcf.Client;
+using Microsoft.ServiceFabric.Actors.Runtime;
+using Microsoft.ServiceFabric.Services.Communication.Wcf;
+using Microsoft.ServiceFabric.Services.Remoting.Runtime;
+using Microsoft.ServiceFabric.Services.Remoting.V2.Client;
+
 namespace Microsoft.ServiceFabric.Actors.Remoting.Wcf
 {
-    using System;
-    using System.Collections.Generic;
-    using Microsoft.ServiceFabric.Actors.Client;
-    using Microsoft.ServiceFabric.Actors.Remoting.V1.Wcf.Client;
-    using Microsoft.ServiceFabric.Actors.Runtime;
-    using Microsoft.ServiceFabric.Services.Communication.Wcf;
-    using Microsoft.ServiceFabric.Services.Remoting.Runtime;
-    using Microsoft.ServiceFabric.Services.Remoting.V2.Client;
-
     /// <summary>
     ///     Sets WCF as the default remoting provider for actors.
     /// </summary>
@@ -71,30 +71,6 @@ public long CloseTimeoutInMilliSeconds
             set;
         }
 
-        /// <summary>
-        ///     Creates a service remoting client factory to connect to the remoted actor interfaces.
-        /// </summary>
-        /// <param name="callbackClient">
-        ///     Client implementation where the callbacks should be dispatched.
-        /// </param>
-        /// <returns>
-        ///     A <see cref="Microsoft.ServiceFabric.Actors.Remoting.V1.Wcf.Client.WcfActorRemotingClientFactory"/>
-        ///     as <see cref="Microsoft.ServiceFabric.Services.Remoting.V1.Client.IServiceRemotingClientFactory"/>
-        ///     that can be used with <see cref="ActorProxyFactory"/> to
-        ///     generate actor proxy to talk to the actor over remoted actor interface.
-        /// </returns>
-        [Obsolete(Services.Remoting.DeprecationMessage.RemotingV1)]
-        public override Microsoft.ServiceFabric.Services.Remoting.V1.Client.IServiceRemotingClientFactory CreateServiceRemotingClientFactory(
-            Microsoft.ServiceFabric.Services.Remoting.V1.IServiceRemotingCallbackClient callbackClient)
-        {
-            return new Microsoft.ServiceFabric.Actors.Remoting.V1.Wcf.Client.WcfActorRemotingClientFactory(
-                WcfUtility.CreateTcpClientBinding(
-                    maxMessageSize: this.GetMaxMessageSize(),
-                    openTimeout: this.GetOpenTimeout(),
-                    closeTimeout: this.GetCloseTimeout()),
-                callbackClient);
-        }
-
         /// <summary>
         ///     Creates a V2 service remoting listener for remoting the actor interfaces.
         /// </summary>
@@ -126,44 +102,21 @@ public override Dictionary<string, Func<ActorService, IServiceRemotingListener>>
         /// </param>
         /// <returns>
         ///     A <see cref="WcfActorRemotingClientFactory"/>
-        ///     as <see cref="Microsoft.ServiceFabric.Services.Remoting.V2.Client.IServiceRemotingClientFactory"/>
+        ///     as <see cref="IServiceRemotingClientFactory"/>
         ///     that can be used with <see cref="ActorProxyFactory"/> to
         ///     generate actor proxy to talk to the actor over remoted actor interface.
         /// </returns>
         public override IServiceRemotingClientFactory CreateServiceRemotingClientFactory(
             IServiceRemotingCallbackMessageHandler callbackMessageHandler)
         {
-            return new Microsoft.ServiceFabric.Actors.Remoting.V2.Wcf.Client.WcfActorRemotingClientFactory(
+            return new WcfActorRemotingClientFactory(
                 WcfUtility.CreateTcpClientBinding(
                     maxMessageSize: this.GetMaxMessageSize(),
                     openTimeout: this.GetOpenTimeout(),
                     closeTimeout: this.GetCloseTimeout()),
                 callbackMessageHandler);
         }
 
-        /// <summary>
-        ///     Creates a service remoting listener for remoting the actor interfaces.
-        /// </summary>
-        /// <param name="actorService">
-        ///     The implementation of the actor service that hosts the actors whose interfaces
-        ///     needs to be remoted.
-        /// </param>
-        /// <returns>
-        ///     An <see cref="IServiceRemotingListener"/>
-        ///     for the specified actor service.
-        /// </returns>
-        [Obsolete(Services.Remoting.DeprecationMessage.RemotingV1)]
-        public override IServiceRemotingListener CreateServiceRemotingListener(
-            ActorService actorService)
-        {
-            return new Actors.Remoting.V1.Wcf.Runtime.WcfActorServiceRemotingListener(
-                actorService,
-                WcfUtility.CreateTcpListenerBinding(
-                    maxMessageSize: this.GetMaxMessageSize(),
-                    openTimeout: this.GetOpenTimeout(),
-                    closeTimeout: this.GetCloseTimeout()));
-        }
-
         private long GetMaxMessageSize()
         {
             return (this.MaxMessageSize > 0) ? this.MaxMessageSize : DefaultMaxMessageSize;