NES import suggestion needs to be more clever

[bpasero]

I now see import suggestions for a lot of things popping up:

//cc @alexdima

[benibenj]

Could you please provide more information on the kind of imports you are seeing which are not "clever". Is it always the same import on the same line being suggested? Or the same wrong import across different lines? ...

[bpasero]

@benibenj in this case I was just renaming options to result manually and the suggested NES fix is here to import options from an entirely unrelated file, only because that happens to exist. Specifically before the edit, options was a local variable and so suggesting an import is not "clever".

[bpasero]

Another example: I just added options here:

[albertosantini]

Well, having many options is always a good strategy, and if you can import them... :) Sorry for the noise. :)

[benibenj]

We have some plans on improving this:

• Requires a recent edit at diagnostic location to show import NES
• If user rejects import suggestion, never show again for that property and file path combination
• If shown for a while and user navigates away or ignores, consider as a rejection

We have a couple more ideas which would cause less import NES to show. This however would make it less reliable which is why we prefer not to do them if not needed.