Skip to content

Commit 3a6b1bb

Browse files
authored
Merge pull request #635 from microsoftgraph/bugfix/linting
bugfix/linting
2 parents 01d1e9f + f39f0b9 commit 3a6b1bb

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

.pylintrc

+2-2
Original file line numberDiff line numberDiff line change
@@ -513,5 +513,5 @@ preferred-modules=
513513

514514
# Exceptions that will emit a warning when being caught. Defaults to
515515
# "BaseException, Exception".
516-
overgeneral-exceptions=BaseException,
517-
Exception
516+
overgeneral-exceptions=builtins.BaseException,
517+
builtins.Exception

src/msgraph_core/base_graph_request_adapter.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
from typing import Optional
12
import httpx
23
from kiota_abstractions.authentication import AuthenticationProvider
34
from kiota_abstractions.serialization import (
@@ -7,7 +8,6 @@
78
SerializationWriterFactoryRegistry,
89
)
910
from kiota_http.httpx_request_adapter import HttpxRequestAdapter
10-
from typing import Optional
1111

1212
from .graph_client_factory import GraphClientFactory
1313

src/msgraph_core/tasks/large_file_upload.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,10 @@
1414

1515
from kiota_abstractions.request_adapter import RequestAdapter
1616

17-
from msgraph_core.models import LargeFileUploadSession, UploadResult, UploadSessionDataHolder # check imports
17+
from msgraph_core.models import LargeFileUploadSession, UploadResult # check imports
1818

1919

20+
# pylint: disable=too-many-instance-attributes
2021
class LargeFileUploadTask:
2122

2223
def __init__(
@@ -128,7 +129,7 @@ async def upload(self, after_chunk_upload: Optional[Callable] = None):
128129
self.next_range = next_range[0] + "-"
129130
process_next = await self.next_chunk(self.stream)
130131

131-
except Exception as error:
132+
except Exception as error: #pylint: disable=broad-except
132133
logging.error("Error uploading chunk %s", error)
133134
finally:
134135
self.chunks -= 1

0 commit comments

Comments
 (0)