Is LoggingCache thread safe?

[ronaldploeger]

Hi,

shouldn' LoggingCache instead of using int for the members 'request' and 'hits'

protected int requests = 0;
protected int hits = 0;

be using AtomicInteger (or probably even better AtomicLong) to be thread safe?

Best regards,
Ronald

[emacarron]

Hi Ronald.

Considering that that counters are just for statistics and the low probabibity of a collision I would say that is better to accept a bit of "vagueness" instead of adding a lock.

[ronaldploeger]

Hi Eduardo,

could be that you are right. Hard to tell without real testing how much "vagueness" this introduces and if using an AtomicInteger would notably degrade performance.

If no AtomicInteger is used I guess at least the members should be made volatile - then at least the visibility problem would be addressed.

Best,
Ronald