uri.`?` doesn't concatenate

[dom96]

I expected ? to not overwrite the query, but to merge. The docs of the proc use the word "concatenate" which implies that this is how the proc should work, but the implementation overwrites the query instead of concatenating.

Example

import uri
let foo = parseUri("https://google.com/?page=10")
echo(foo ? {"test": "42"})

Current Output

https://google.com/?test=42

Expected Output

https://google.com/?page=10&test=42

Possible Solution

Workaround is:

echo(foo ? (toSeq(foo.query.decodeQuery()) & @({"test": "42"})))

We can either change the semantics behind a feature flag (to avoid breaking existing code) or update the docs.

[juancarlospaco]

Instead make a new ? proc with fixes and works in-place not returning a new Uri.
Also usually the "key" part is static and can be unrolled in another overload too.
Can use sugar.dup if need a new Uri for whatever reason.

[sgmihai]

I am waiting for a long time for this issue to be fixed. What exactly is needed for the fix to get merged for the next version ?

[Araq]

A pull request?

[sgmihai]

I see there is already a pull request

[Araq]

Where?

[ringabout]

=> #19800

[sgmihai]

Bump. It's been a year :(