Skip to content

Set exit code when commands fail #442

Open
@mmarchini

Description

@mmarchini

If I run git node land on a new machine with nothing configured, I'll get the instructions to set required variables, and then the process will exit with status code 0. In order for us to be able to use ncu on a Commit Queue, it needs to return the appropriate status codes when something goes wrong, otherwise automation won't work.

(I didn't check which other failures will exit with 0, but all failures should set the exit code to a non-zero code)

Activity

added a commit that references this issue on Jun 27, 2020
added a commit that references this issue on Jun 27, 2020
codebytere

codebytere commented on Jun 28, 2020

@codebytere
Member

Closed by #443

mmarchini

mmarchini commented on Jun 28, 2020

@mmarchini
ContributorAuthor

I'd like to keep this open because there are still many situations where the exit code will return zero even if the command failed. Would be good for us to list those as a next step.

github-actions

github-actions commented on Sep 27, 2020

@github-actions
Contributor

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

5 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @codebytere@targos@mmarchini

        Issue actions

          Set exit code when commands fail · Issue #442 · nodejs/node-core-utils