buffer and git views are not async resulting in UI lag when git is enabled

[peterlvilim]

My config:
enable_refresh_on_write = true,
-- todo fix
enable_git_status = true,
filesystem = {bind_to_cwd = true, follow_current_file = true},
buffer = {bind_to_cwd = true},
git_status = {bind_to_cwd = true}

I was seeing lag with buffer and git views. Turning off git helped. I used https://github.com/stevearc/profile.nvim and saw that it was blocked for awhile while running git command. Looked through code and filesystem seems async (and works fine in my testing) but the other two aren't.

Was thinking of fixing this. Any reason it is the way it is or could I go ahead and try?

[cseickel]

Any reason it is the way it is or could I go ahead and try?

There's no reason other than that they don't get as much use as the filesystem and no one has complained about the performance before, so they are still at the initial implementation while filesystem has had a ton of optimization and refactoring.

Please feel free to make the other two sync as well.

[peterlvilim]

I'm part way through the diff and thinking of just dropping all support for non-async and eliminating that config flag since it would simplify code (fewer branches) and eliminate some code. Thoughts? I can preserve the non-async option, but I don't really know why anyone would want to use it.

[cseickel]

The sync options are still needed in some places. Some people don't like the flicker associated with things loading asynchronously and would prefer to just wait another 50 milliseconds for a single update. Technically I think it is faster in certain situations.