Skip to content

Commit dfdfe0b

Browse files
committed
[IMP] website: adapt tours
* snippet_popup_and_scrollbar
1 parent e9ea17d commit dfdfe0b

File tree

2 files changed

+24
-26
lines changed

2 files changed

+24
-26
lines changed

addons/website/static/tests/tours/snippet_popup_and_scrollbar.js

Lines changed: 18 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ const checkScrollbar = function (hasScrollbar) {
3333
};
3434
};
3535

36-
const toggleBackdrop = function () {
37-
return changeOption('SnippetPopup', 'we-button[data-name="popup_backdrop_opt"] we-checkbox', 'backdrop');
36+
function toggleBackdrop(snippet) {
37+
return changeOption(`${snippet}`, "[data-action-id='setBackdrop'] .form-check-input");
3838
};
3939

4040
registerWebsitePreviewTour("snippet_popup_and_scrollbar", {
@@ -49,17 +49,17 @@ registerWebsitePreviewTour("snippet_popup_and_scrollbar", {
4949
trigger: ':iframe .s_popup .modal',
5050
run: "click",
5151
},
52-
toggleBackdrop(), // hide Popup backdrop
52+
toggleBackdrop("Popup"), // hide Popup backdrop
5353
checkScrollbar(true),
5454
goBackToBlocks(),
5555
{
5656
content: "Drag the Content snippet group and drop it at the bottom of the popup.",
57-
trigger: '#oe_snippets .oe_snippet[name="Content"] .oe_snippet_thumbnail:not(.o_we_ongoing_insertion)',
57+
trigger: '.o-snippets-menu .o_snippet[name="Content"] .o_snippet_thumbnail:not(.o_we_ongoing_insertion)',
5858
run: "drag_and_drop :iframe #wrap .s_popup .oe_drop_zone:last",
5959
},
6060
{
6161
content: "Click on the s_media_list snippet.",
62-
trigger: ':iframe .o_snippet_preview_wrap[data-snippet-id="s_media_list"]',
62+
trigger: ':iframe .o_add_snippets_preview [data-snippet="s_media_list"]',
6363
run: "click",
6464
},
6565
checkScrollbar(false),
@@ -70,12 +70,11 @@ registerWebsitePreviewTour("snippet_popup_and_scrollbar", {
7070
},
7171
{
7272
content: "Remove the Media List snippet in the Popup.",
73-
trigger: ":iframe .oe_overlay.oe_active .oe_snippet_remove",
73+
trigger: "body .o_overlay_options .oe_snippet_remove",
7474
run: "click",
7575
},
76+
toggleBackdrop("Popup"), // show Popup backdrop
7677
checkScrollbar(true),
77-
toggleBackdrop(), // show Popup backdrop
78-
checkScrollbar(false),
7978
{
8079
content: "Close the Popup that has now backdrop.",
8180
trigger: ".o_we_invisible_el_panel .o_we_invisible_entry:first",
@@ -88,9 +87,8 @@ registerWebsitePreviewTour("snippet_popup_and_scrollbar", {
8887
run: "click",
8988
},
9089
checkScrollbar(true),
91-
toggleBackdrop(), // show Cookies Bar backdrop
92-
checkScrollbar(false),
93-
toggleBackdrop(), // hide Cookies Bar backdrop
90+
toggleBackdrop("Cookies Bar"), // show Cookies Bar backdrop
91+
toggleBackdrop("Cookies Bar"), // hide Cookies Bar backdrop
9492
checkScrollbar(true),
9593
{
9694
content: "Open the Popup that has backdrop.",
@@ -103,12 +101,12 @@ registerWebsitePreviewTour("snippet_popup_and_scrollbar", {
103101
goBackToBlocks(),
104102
{
105103
content: "Drag the Content snippet group and drop it at the bottom of the popup.",
106-
trigger: '#oe_snippets .oe_snippet[name="Content"] .oe_snippet_thumbnail:not(.o_we_ongoing_insertion)',
104+
trigger: '.o-snippets-menu .o_snippet[name="Content"] .o_snippet_thumbnail:not(.o_we_ongoing_insertion)',
107105
run: "drag_and_drop :iframe #wrap .s_popup .oe_drop_zone:last",
108106
},
109107
{
110108
content: "Click on the s_media_list snippet.",
111-
trigger: ':iframe .o_snippet_preview_wrap[data-snippet-id="s_media_list"]',
109+
trigger: ':iframe .o_add_snippets_preview [data-snippet="s_media_list"]',
112110
run: "click",
113111
},
114112
/* task-4185877
@@ -121,7 +119,7 @@ registerWebsitePreviewTour("snippet_popup_and_scrollbar", {
121119
},
122120
{
123121
content: "Remove the s_popup snippet",
124-
trigger: ".o_we_customize_panel we-customizeblock-options:contains('Popup') we-button.oe_snippet_remove:first",
122+
trigger: ".o_customize_tab .options-container[data-container-title='Popup'] .oe_snippet_remove",
125123
async run(helpers) {
126124
await helpers.click();
127125
// TODO: remove the below setTimeout. Without it, goBackToBlocks() not works.
@@ -132,12 +130,12 @@ registerWebsitePreviewTour("snippet_popup_and_scrollbar", {
132130
goBackToBlocks(),
133131
{
134132
content: "Drag the Content snippet group and drop it in the Cookies Bar.",
135-
trigger: '#oe_snippets .oe_snippet[name="Content"] .oe_snippet_thumbnail:not(.o_we_ongoing_insertion)',
133+
trigger: '.o-snippets-menu .o_snippet[name="Content"] .o_snippet_thumbnail:not(.o_we_ongoing_insertion)',
136134
run: "drag_and_drop :iframe #website_cookies_bar .modal-content.oe_structure",
137135
},
138136
{
139137
content: "Click on the s_media_list snippet.",
140-
trigger: ':iframe .o_snippet_preview_wrap[data-snippet-id="s_media_list"]',
138+
trigger: ':iframe .o_add_snippets_preview [data-snippet="s_media_list"]',
141139
run: "click",
142140
},
143141
{
@@ -147,21 +145,17 @@ registerWebsitePreviewTour("snippet_popup_and_scrollbar", {
147145
},
148146
{
149147
content: "Duplicate the Media List snippet",
150-
trigger: ".o_we_customize_panel we-customizeblock-options:contains('Media List') we-button.oe_snippet_clone:first",
151-
run() {
152-
// TODO: use run: "click", instead
153-
this.anchor.click();
154-
}
148+
trigger:".o_customize_tab .options-container[data-container-title='Media List'] button.oe_snippet_clone",
149+
run: "click",
155150
},
156-
checkScrollbar(false),
157151
{
158152
content: "Remove the first Media List snippet in the Cookies Bar.",
159-
trigger: ":iframe .oe_overlay.oe_active .oe_snippet_remove",
153+
trigger: "body .o_overlay_options .oe_snippet_remove",
160154
run: "click",
161155
},
162156
{
163157
content: "Remove the second Media List snippet in the Cookies Bar.",
164-
trigger: ":iframe .oe_overlay.oe_active .oe_snippet_remove",
158+
trigger: "body .o_overlay_options .oe_snippet_remove",
165159
run: "click",
166160
},
167161
checkScrollbar(true),

addons/website/tests/test_snippets.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,12 +120,16 @@ def test_12_snippet_images_wall(self):
120120
self.start_tour('/', 'snippet_images_wall', login='admin')
121121

122122
@unittest.skip
123-
def test_snippet_popup_with_scrollbar_and_animations(self):
123+
def test_snippet_popup_with_animations(self):
124124
website = self.env.ref('website.default_website')
125125
website.cookies_bar = True
126-
self.start_tour(self.env['website'].get_client_action_url('/'), 'snippet_popup_and_scrollbar', login='admin')
127126
self.start_tour(self.env['website'].get_client_action_url('/'), 'snippet_popup_and_animations', login='admin', timeout=90)
128127

128+
def test_snippet_popup_with_scrollbar(self):
129+
website = self.env.ref('website.default_website')
130+
website.cookies_bar = True
131+
self.start_tour(self.env['website'].get_client_action_url('/'), 'snippet_popup_and_scrollbar', login='admin')
132+
129133
@unittest.skip
130134
def test_drag_and_drop_on_non_editable(self):
131135
self.start_tour(self.env['website'].get_client_action_url('/'), 'test_drag_and_drop_on_non_editable', login='admin')

0 commit comments

Comments
 (0)