Skip to content

observer::variables_connected() is never called #293

Open
@eidekrist

Description

@eidekrist

Before merge of #295, execution::add_observer(observer o) would call o->variables_connected() for all connected variables. Because a connection now is an object and no longer a one-to-one relationship between two variables, that call was omitted.

We should either:

  1. Change observer::variables_connected(output, input) to observer:.connection_added(std::shared_ptr<connection> conn)
    or
  2. When in doubt leave it out: Remove observer::variables_connected().

Since we have added execution::get_connections(), using an observer to register that a connection was added becomes less necessary.

The same goes for observer::variable_disconnected().

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions