Skip to content

Confusing and redundant errors from load_cse_config() #413

Open
@kyllingstad

Description

@kyllingstad

While implementing support for the new configuration format in CSE CLI, I tried to pass a path to a directory that does not contain any OspSystemStructure.xml file to cse_load_config(). The result was three error messages, two of which are the same:

error: :0:0 unable to open primary document entity 'C:\Users\larky\Development\osp\build-x64\cse-cli\..\..\cse-core\test\data\OspSystemStructure.xml'
error: Validation of C:\Users\larky\Development\osp\build-x64\cse-cli\..\..\cse-core\test\data\OspSystemStructure.xml failed.
error: Validation of C:\Users\larky\Development\osp\build-x64\cse-cli\..\..\cse-core\test\data\OspSystemStructure.xml failed.

I don't know where the first one comes from. The second one appears to be logged by cse-core, while the third is printed by cse-cli based on the message in an exception thrown by cse-core.

As a user of both cse-core and cse-cli, I would expect exactly one thing to happen: I get an exception/error that says "Directory 'X' does not contain OspSystemStructure.xml", or something like that.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions