Skip to content

Commit b58c3cc

Browse files
committedApr 17, 2018
Update release.sh
1 parent c20ac8b commit b58c3cc

File tree

1 file changed

+11
-14
lines changed

1 file changed

+11
-14
lines changed
 

‎Scripts/release.sh

+11-14
Original file line numberDiff line numberDiff line change
@@ -85,10 +85,17 @@ if [ "$versions_valid" != "y" ]; then
8585
exit 1
8686
fi;
8787

88-
# ---- Build the universal frameworks ----
89-
printf "\n\n4. Building the universal frameworks...\n\n"
90-
xcodebuild -workspace OptimizelySDK.xcworkspace -scheme OptimizelySDKiOS-Universal -configuration Release
91-
xcodebuild -workspace OptimizelySDK.xcworkspace -scheme OptimizelySDKTVOS-Universal -configuration Release
88+
# ---- Build universal frameworks ----
89+
printf "\n\n4. Building universal frameworks.\n\n"
90+
printf "Build universal frameworks? (We recommend no, not here.)\n"
91+
printf "(You should have done this earlier in the #.#.# branch that P.R.'s on a #.#.x branch.)"
92+
read -n 1 -p "[y/n] $cr? " build_universal;
93+
if [ "$build_universal" == "y" ]; then
94+
Xcodebuild -workspace OptimizelySDK.xcworkspace -scheme OptimizelySDKiOS-Universal -configuration Release
95+
Xcodebuild -workspace OptimizelySDK.xcworkspace -scheme OptimizelySDKTVOS-Universal -configuration Release
96+
printf "\nPlease commit your change.\n"
97+
exit 1
98+
fi
9299

93100
# ---- Update podspec files ----
94101
printf "\n\n5. Updating podspec files with the new version numbers...\n\n"
@@ -211,16 +218,6 @@ printf "\nCorrect the podspec(s) before proceeding. Delete tag and retag the fix
211218
exit 1
212219
fi;
213220

214-
# ---- commit podspec changes ----
215-
printf "\n"
216-
read -n 1 -p "7. Commit and push version bump changes to master? Skip this step if it has already been done. [y/n] $cr? " podspec_valid;
217-
if [ "$podspec_valid" == "y" ]; then
218-
printf "\nCommitting and pushing master with version bump changes...\n";
219-
git add -u
220-
git commit -m "Bumped version for new release."
221-
git push origin devel
222-
fi;
223-
224221
# ---- git tag all modules----
225222
printf "\n\n8. Tagging all modules...\n";
226223
printf "Tagging core-$OPTIMIZELY_SDK_CORE_VERSION\n";

0 commit comments

Comments
 (0)
Please sign in to comment.