Skip to content

Commit 8624e1e

Browse files
author
Paul V Craven
committed
Update tests
1 parent f4c8173 commit 8624e1e

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

optimizely/config_manager.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,7 @@ def fetch_datafile(self) -> None:
404404

405405
session.mount('http://', adapter)
406406
session.mount("https://", adapter)
407-
response = session.get(self.datafile_url, timeout=enums.ConfigManager.REQUEST_TIMEOUT)
407+
response = session.get(self.datafile_url, headers=request_headers, timeout=enums.ConfigManager.REQUEST_TIMEOUT)
408408
except requests_exceptions.RequestException as err:
409409
self.logger.error(f'Fetching datafile from {self.datafile_url} failed. Error: {err}')
410410
return
@@ -495,7 +495,7 @@ def fetch_datafile(self) -> None:
495495

496496
session.mount('http://', adapter)
497497
session.mount("https://", adapter)
498-
response = session.get(self.datafile_url, timeout=enums.ConfigManager.REQUEST_TIMEOUT)
498+
response = session.get(self.datafile_url, headers=request_headers, timeout=enums.ConfigManager.REQUEST_TIMEOUT)
499499
except requests_exceptions.RequestException as err:
500500
self.logger.error(f'Fetching datafile from {self.datafile_url} failed. Error: {err}')
501501
return

tests/test_config_manager.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -516,8 +516,9 @@ def test_fetch_datafile__exception_polling_thread_failed(self, _):
516516
# verify the error log message
517517
log_messages = [args[0] for args, _ in mock_logger.error.call_args_list]
518518
for message in log_messages:
519+
print(message)
519520
if "Thread for background datafile polling failed. " \
520-
"Error: timestamp too large to convert to C _PyTime_t" not in message:
521+
"Error: timestamp too large to convert to C PyTime_t" not in message:
521522
assert False
522523

523524
def test_is_running(self, _):

tests/test_event_dispatcher.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def test_dispatch_event__post_request(self):
4646
}
4747
event = event_builder.Event(url, params, http_verb='POST', headers={'Content-Type': 'application/json'})
4848

49-
with mock.patch('requests.post') as mock_request_post:
49+
with mock.patch('requests.Session.post') as mock_request_post:
5050
event_dispatcher.EventDispatcher.dispatch_event(event)
5151

5252
mock_request_post.assert_called_once_with(
@@ -69,7 +69,7 @@ def test_dispatch_event__handle_request_exception(self):
6969
event = event_builder.Event(url, params, http_verb='POST', headers={'Content-Type': 'application/json'})
7070

7171
with mock.patch(
72-
'requests.post', side_effect=request_exception.RequestException('Failed Request'),
72+
'requests.Session.post', side_effect=request_exception.RequestException('Failed Request'),
7373
) as mock_request_post, mock.patch('logging.error') as mock_log_error:
7474
event_dispatcher.EventDispatcher.dispatch_event(event)
7575

0 commit comments

Comments
 (0)