update eslint

Author: Steffan

.circleci/config.yml

@@ -24,6 +24,9 @@ jobs:
           key: yarn-{{ checksum "yarn.lock" }}
           paths:
             - ~/.yarn
+      - run:
+          name: Lint JavaScript
+          command: yarn run eslint
       - run:
           name: Run Tests
           command: |

.eslintrc.js

@@ -1,44 +1,46 @@
 module.exports = {
-  "root":true,
-  "env": {
-      "es6": true,
-      "browser": true,
-      "commonjs": true,
-  },
-  "extends": [
-      "eslint:recommended"
-  ],
-  "parserOptions": {
-      "sourceType": "module"
-  },
-  "rules": {
-      "brace-style": ["error", "1tbs", {"allowSingleLine": true}],
-      "comma-style": "error",
-      "comma-spacing": "error",
-      "eqeqeq": ["off", "smart"],
-      "indent": "off",
-      "indent-legacy": ["error", 4, {"SwitchCase": 1}],
-      "key-spacing": "error",
-      "keyword-spacing": "error",
-      "linebreak-style": ["error", "unix"],
-      "no-multi-spaces": "error",
-      "no-trailing-spaces": "error",
-      "no-lone-blocks": "error",
-      "no-extend-native": "error",
-      "no-unused-vars": ["error", {"vars": "local", "args": "none"}],
-      "no-empty": ["error", {"allowEmptyCatch": true}],
-      "no-duplicate-imports": "error",
-      "no-array-constructor": "error",
-      "no-multiple-empty-lines": "error",
-      "no-template-curly-in-string": "error",
-      "no-console": "off",
-      "object-curly-spacing": "error",
-      "quotes": ["error", "single", {"avoidEscape": true}],
-      "semi": ["error", "always"],
-      "space-infix-ops": "error",
-      "space-unary-ops": "error",
-      "space-in-parens": "error",
-      "space-before-blocks": "error",
-      "template-curly-spacing": "error"
-  }
+    "root": true,
+    "env": {
+        "es6": true,
+        "browser": true,
+        "commonjs": true,
+    },
+    "extends": [
+        "eslint:recommended"
+    ],
+    "parserOptions": {
+        "sourceType": "module"
+    },
+    "rules": {
+        "brace-style": ["error", "1tbs", {"allowSingleLine": true}],
+        "comma-style": "error",
+        "comma-spacing": "error",
+        "eqeqeq": ["off", "smart"],
+        "indent": "off",
+        "indent-legacy": ["error", 4, {"SwitchCase": 1}],
+        "key-spacing": "error",
+        "keyword-spacing": "error",
+        "linebreak-style": ["error", "unix"],
+        "no-var": "error",
+        "no-multi-spaces": "error",
+        "no-trailing-spaces": "error",
+        "no-lone-blocks": "error",
+        "no-extend-native": "error",
+        "no-unused-vars": ["error", {"vars": "local", "args": "none"}],
+        "no-empty": ["error", {"allowEmptyCatch": true}],
+        "no-duplicate-imports": "error",
+        "no-array-constructor": "error",
+        "no-multiple-empty-lines": "error",
+        "no-template-curly-in-string": "error",
+        "no-console": "off",
+        "object-curly-spacing": "error",
+        "prefer-const": "error",
+        "quotes": ["error", "single", {"avoidEscape": true}],
+        "semi": ["error", "always"],
+        "space-infix-ops": "error",
+        "space-unary-ops": "error",
+        "space-in-parens": "error",
+        "space-before-blocks": "error",
+        "template-curly-spacing": "error"
+    }
 };

build/build.js

@@ -1,11 +1,11 @@
 /* eslint-env node */
 
-var fs = require('fs');
-var rollup = require('rollup');
-var uglify = require('uglify-js');
-var buble = require('rollup-plugin-buble');
-var {version} = require('../package.json');
-var banner =
+const fs = require('fs');
+const rollup = require('rollup');
+const uglify = require('uglify-js');
+const buble = require('rollup-plugin-buble');
+const {version} = require('../package.json');
+const banner =
     '/*!\n' +
     ' * vue-event-manager v' + version + '\n' +
     ' * https://github.com/pagekit/vue-event-manager\n' +

build/release.js

@@ -1,7 +1,7 @@
 /* eslint-env node */
 
-var replace = require('replace-in-file');
-var version = process.argv[2];
+const replace = require('replace-in-file');
+const version = process.argv[2];
 
 replace({
     files: 'package.json',

package.json

@@ -22,8 +22,10 @@
   },
   "scripts": {
     "karma": "karma start test/karma.conf.js --single-run",
-    "build": "node build/build.js",
-    "release": "node build/release.js"
+    "build": "node ./build/build.js",
+    "release": "node ./build/release.js",
+    "eslint": "eslint .",
+    "eslint-fix": "eslint . --fix"
   },
   "devDependencies": {
     "buble": "^0.18.0",
@@ -38,9 +40,9 @@
     "karma-safari-launcher": "^1.0.0",
     "karma-webpack": "^2.0.9",
     "replace-in-file": "^3.1.0",
-    "rollup": "^0.55.1",
+    "rollup": "^0.55.3",
     "rollup-plugin-buble": "^0.18.0",
-    "uglify-js": "^3.2.2",
+    "uglify-js": "^3.3.9",
     "vue": "^2.5.13",
     "webpack": "^3.10.0"
   }

src/EventManager.js

@@ -12,9 +12,8 @@ export default class EventManager {
 
     on(event, callback, priority = 0) {
 
-        var listeners = this.listeners[event] || [], index;
-
-        index = listeners.findIndex(listener => listener.priority < priority);
+        const listeners = this.listeners[event] || [];
+        const index = listeners.findIndex(listener => listener.priority < priority);
 
         if (~index) {
             listeners.splice(index, 0, {callback, priority});
@@ -33,11 +32,11 @@ export default class EventManager {
             delete this.listeners[event];
         }
 
-        var listeners = this.listeners[event], index;
+        const listeners = this.listeners[event];
 
         if (listeners && callback) {
 
-            index = listeners.findIndex(listener => listener.callback === callback);
+            const index = listeners.findIndex(listener => listener.callback === callback);
 
             if (~index) {
                 listeners.splice(index, 1);
@@ -53,7 +52,7 @@ export default class EventManager {
 
         return ((this.listeners[event] || []).concat()).reduce((result, listener) => {
 
-            var callback = result => {
+            const callback = result => {
 
                 if (result === false) {
                     return result;

src/index.js

@@ -5,7 +5,7 @@
 import EventManager from './EventManager';
 import {forEach, isArray, isObject} from './util';
 
-var Events = new EventManager();
+const Events = new EventManager();
 
 Events.install = function (Vue) {
 
@@ -21,14 +21,15 @@ Events.install = function (Vue) {
 
 function initEvents() {
 
-    var {events} = this.$options, _events = [];
+    const _events = [];
+    const {events} = this.$options;
 
     if (events) {
 
         forEach(events, (listeners, event) => {
             forEach(isArray(listeners) ? listeners : [listeners], listener => {
 
-                var priority = 0;
+                let priority = 0;
 
                 if (isObject(listener)) {
                     priority = listener.priority;
@@ -48,7 +49,7 @@ function bindListener(fn, vm) {
     if (typeof fn === 'string') {
         return function () {
             return vm[fn].apply(vm, arguments);
-        }
+        };
     }
 
     return fn.bind(vm);

src/util.js

@@ -32,14 +32,15 @@ if (!Array.prototype.findIndex) {
                 throw new TypeError('predicate must be a function');
             }
 
-            var o = Object(this);
-            var len = o.length >>> 0;
-            var thisArg = arguments[1];
-            var k = 0;
+            const o = Object(this);
+            const len = o.length >>> 0;
+            const thisArg = arguments[1];
+
+            let k = 0;
 
             while (k < len) {
 
-                var kValue = o[k];
+                const kValue = o[k];
 
                 if (predicate.call(thisArg, kValue, k, o)) {
                     return k;

yarn.lock

@@ -3454,9 +3454,9 @@ rollup-pluginutils@^2.0.1:
     estree-walker "^0.3.0"
     micromatch "^2.3.11"
 
-rollup@^0.55.1:
-  version "0.55.1"
-  resolved "https://registry.yarnpkg.com/rollup/-/rollup-0.55.1.tgz#baf4f23abe3014b29e56dea7d72d9946e56ac7dd"
+rollup@^0.55.3:
+  version "0.55.3"
+  resolved "https://registry.yarnpkg.com/rollup/-/rollup-0.55.3.tgz#0af082a766d51c3058430c8372442ff5207d8736"
 
 run-async@^2.2.0:
   version "2.3.0"
@@ -3947,9 +3947,9 @@ uglify-js@^2.8.29:
   optionalDependencies:
     uglify-to-browserify "~1.0.0"
 
-uglify-js@^3.2.2:
-  version "3.3.8"
-  resolved "https://registry.yarnpkg.com/uglify-js/-/uglify-js-3.3.8.tgz#51e9a5db73afb53ac98603d08224edcd0be45fd8"
+uglify-js@^3.3.9:
+  version "3.3.9"
+  resolved "https://registry.yarnpkg.com/uglify-js/-/uglify-js-3.3.9.tgz#33869666c8ab7f7658ce3d22f0f1ced40097d33a"
   dependencies:
     commander "~2.13.0"
     source-map "~0.6.1"