Skip to content

feat: Add CSP options to dashboard #2393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Feb 20, 2023

New Pull Request Checklist

Issue Description

Currently, Parse Dashboard cannot be used with strict CSP

Closes: #2392

Approach

Adds dashboard options:

  • options.strictCSP, which sets the express app's CSP to strict
  • options.CSPNonce, which is a string that can be used to set nonce, in case the developer wants to override

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title feat: add CSP options to dashboard feat: Add CSP options to dashboard Feb 20, 2023
@parse-github-assistant
Copy link

parse-github-assistant bot commented Feb 20, 2023

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@dblythy
Copy link
Member Author

dblythy commented Feb 20, 2023

I'm going to set strictCSP to true so we can preview the PR

@uffizzi-cloud
Copy link

uffizzi-cloud bot commented Feb 20, 2023

Uffizzi Ephemeral Environment deployment-16677

☁️ https://pr-2393-deployment-16677-parse-dashboard.app.uffizzi.com

📄 View Application Logs etc.

What is Uffizzi? Learn more

@dblythy dblythy marked this pull request as draft February 20, 2023 05:38
@dblythy dblythy closed this Feb 20, 2023
@dblythy dblythy reopened this Feb 20, 2023
@uffizzi-cloud
Copy link

uffizzi-cloud bot commented Feb 20, 2023

Preview failed: invalid compose
       Uffizzi was unable to deploy a preview of this pull request because the compose file in this branch is invalid.

@dblythy dblythy closed this Feb 20, 2023
@dblythy dblythy reopened this Feb 20, 2023
@uffizzi-cloud
Copy link

uffizzi-cloud bot commented Feb 20, 2023

Preview failed: invalid compose
       Uffizzi was unable to deploy a preview of this pull request because the compose file in this branch is invalid.

@dblythy dblythy closed this Jun 9, 2023
@mtrezza
Copy link
Member

mtrezza commented Jun 9, 2023

Any specific reason this has been closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse Dashboard has Insecure Content Security
2 participants