Skip to content

Add performance impact CI step #7610

Open
@mtrezza

Description

@mtrezza

New Feature / Enhancement Checklist

  • I am not disclosing a vulnerability.
    I am not just asking a question.
    I have searched through existing issues.

Current Limitation

Parse Server has no CI check to compare performance impact of a PR before merging.

Feature / Enhancement Description

Add performance impact CI check to validate a positive / prevent negative performance impact of a change.

  • The perf impact should be displayed inside the PR thread, either as a check status message with link to a more detailed page, or an auto-updated comment.
  • There are some internal tools available such as the Parse GitHub Assistant that could run a performance script on a branch and update a CI check accordingly.
  • If you want to take on this issue as part of the Bounty Program, it is recommended to begin a discussion about how to design and implement this.

Example Use Case

n/a

Alternatives / Workarounds

n/a

Activity

parse-github-assistant

parse-github-assistant commented on Oct 9, 2021

@parse-github-assistant

Thanks for opening this issue!

  • 🎉 We are excited about your ideas for improvement!
mtrezza

mtrezza commented on Oct 14, 2021

@mtrezza
MemberAuthor

Possibly this:
https://github.com/marketplace/actions/continuous-benchmark
benchmark-action/github-action-benchmark#68

We can simply use the perf measure API of Node 16 and the tool above can read and process it.

@dplewis Could that replace our internal benchmark tool?

added
bounty:$100Bounty applies for fixing this issue (Parse Bounty Program)
on Oct 14, 2021
pinned this issue on Mar 27, 2022
unpinned this issue on Mar 28, 2022
dblythy

dblythy commented on Mar 8, 2023

@dblythy
Member

Possibly a duplicate of #7610

mtrezza

mtrezza commented on Mar 8, 2023

@mtrezza
MemberAuthor

This is #7610 🙃

dblythy

dblythy commented on Mar 8, 2023

@dblythy
Member

Oops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bounty:$100Bounty applies for fixing this issue (Parse Bounty Program)type:ciCI related issue

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @dblythy@mtrezza

        Issue actions

          Add performance impact CI step · Issue #7610 · parse-community/parse-server