User is always being detected as new when logged in through Facebook, Twitter, or Google

[Meglali20]

New Issue Checklist

• I am not disclosing a vulnerability.
• I am not just asking a question.
• I have searched through existing issues.
• I can reproduce the issue with the latest version of Parse Server.

Issue Description

-A user is being detected as new when he isn't.
-authData field being deleted for unknown reasons.

Steps to reproduce

Add the following code to the cloud code and try to login using Facebook, Twitter, or Google.

Parse.Cloud.afterSave(Parse.User, async (request) => {
    if (!request.original) {
       "need to perform some actions here when a user has just signed up"
      }
});

Actual Outcome

This issue leads to performing unwanted actions over a non new user.
After a user performs a login/signup through Facebook, Twitter, or Google, the user is always being detected as a new user in afterSave.
When checking again in the database you can see that the same user has just logged in and it's not a new one,
Noticed also something with the authData field, when testing login with different methods the authData is being erased(doesn't happen all the time).

Expected Outcome

Not detect a user as a new one when he isn't.

Environment

Server

• Parse Server version: parse-server@5.0.0-alpha.3
• Operating system: Windows 10
• Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): Local

Database

• System (MongoDB or Postgres): MongoDB
• Database version: FILL_THIS_OUT
• Local or remote host (MongoDB Atlas, mLab, AWS, Azure, Google Cloud, etc): MongoDB Atlas

Client

• SDK (iOS, Android, JavaScript, PHP, Unity, etc): Android
• SDK version: 1.26.0

Logs

[parse-github-assistant]

Thanks for opening this issue!

• ❌ Please fill out all fields with a placeholder FILL_THIS_OUT, otherwise your issue will be closed. If a field does not apply to the issue, fill in n/a.

[mtrezza]

Can you please correct your example code and provide a full example to reproduce the issue, including user creation.

[Meglali20]

@mtrezza
The code I am performing in afterSave is just the creation of data related to the user in other classes, the code works fine when the user signs up or login/edit his information using the parse-server method, you can just print a message inside the condition where you check if the user is new or no.

Parse.Cloud.afterSave(Parse.User, async (request) => {
    if (!request.original) {
       console.log("user just signed up");
      }
    else{
        console.log("user updated");
      }
});

from the client-side this is a an example of Twitter login

 
    binding.twitterLoginButton.setOnClickListener(view -> ParseTwitterUtils.logIn(MainActivity.this, new LogInCallback() {
            @Override
            public void done(ParseUser user, ParseException err) {
                if (user == null) {
                    Timber.i("Uh oh. The user cancelled the Twitter login.");
                } else if (user.isNew()) {
                 startActivity(new Intent(MainActivity.this, WelcomeUserActivity.class));
                    Timber.i("User signed up and logged in through Twitter!");
                } else {
               startActivity(new Intent(MainActivity.this, HomeActivity.class));
                    Timber.i("User logged in through Twitter!");
                }
                if (err != null) {
                    Timber.e("ERROR TWITTER LOGIN " + err.getMessage());
                }
            }
        }));

From the client-side when a user is already signed up it performs the required action as the user isn't new but from the server-side there is the issue I opend.

[mtrezza]

Since you say this is a server issue, are you able to reproduce this solely in Cloud Code (or via the REST API) without using the client? That way you could add a failing test and we can exclude the client as a source of error.

[Meglali20]

@mtrezza is it possible to perform twitter or google login using REST API or in cloud code? if yes, how so I can test it. what made me think that it's a problem from the server side is when I change the information of a normal user from the client-side and save it from the client it's working correctly. also when using (all 3 alternative login methods Facebook, Twitter, and Google) the problem occurs but not with a normal account.

[mtrezza]

In Cloud Code you would do it like you'd do it using the Parse JS SDK.

[Meglali20]

I tried Facebook login with the Parse JS SDK, the same issue occurs. Tried to run a fail test but I keep getting this error

npm run coverage

> parse-server@5.0.0-alpha.13 coverage C:\Users\megla\Desktop\Parse\parse-server
> cross-env MONGODB_VERSION=${MONGODB_VERSION:=4.4.10} MONGODB_TOPOLOGY=${MONGODB_TOPOLOGY:=standalone} MONGODB_STORAGE_ENGINE=${MONGODB_STORAGE_ENGINE:=wiredTiger} TESTING=1 nyc jasmine

internal/modules/cjs/loader.js:491
  throw new ERR_PACKAGE_PATH_NOT_EXPORTED(basePath, mappingKey);
  ^

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './public/extractFiles.js' is not defined by "exports" in C:\Users\megla\Desktop\Parse\parse-server\node_modules\extract-files\package.json
    at applyExports (internal/modules/cjs/loader.js:491:9)
    at resolveExports (internal/modules/cjs/loader.js:507:23)
    at Function.Module._findPath (internal/modules/cjs/loader.js:635:31)
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:1007:27)
    at Function.Module._load (internal/modules/cjs/loader.js:890:27)
    at Module.require (internal/modules/cjs/loader.js:1080:19)
    at require (internal/modules/cjs/helpers.js:72:18)
    at Object.<anonymous> (C:\Users\megla\Desktop\Parse\parse-server\node_modules\@graphql-tools\links\node_modules\apollo-upload-client\public\createUploadLink.js:13:22)
    at Module._compile (internal/modules/cjs/loader.js:1176:30)
    at Module.replacementCompile (C:\Users\megla\Desktop\Parse\parse-server\node_modules\append-transform\index.js:60:13) {
  code: 'ERR_PACKAGE_PATH_NOT_EXPORTED'
}

=============================== Coverage summary ===============================
Statements   : 8.74% ( 1028/11757 )
Branches     : 0.48% ( 37/7629 )
Functions    : 1.01% ( 23/2277 )
Lines        : 8.84% ( 1027/11618 )
================================================================================
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! parse-server@5.0.0-alpha.13 coverage: `cross-env MONGODB_VERSION=${MONGODB_VERSION:=4.4.10} MONGODB_TOPOLOGY=${MONGODB_TOPOLOGY:=standalone} MONGODB_STORAGE_ENGINE=${MONGODB_STORAGE_ENGINE:=wiredTiger} 
TESTING=1 nyc jasmine`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the parse-server@5.0.0-alpha.13 coverage script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\megla\AppData\Roaming\npm-cache\_logs\2021-12-09T15_53_34_413Z-debug.log

[mtrezza]

Could you open a PR with the failing test that demonstrates the issue?

[Meglali20]

@mtrezza sure I would like to do that, I even tried to do it check my previous comment, I keep getting the same error any idea on how to proceed?

[mtrezza]

try to use npm test spec/<filename>.spec.js to run the test; again I suggest you publish your test in a PR so we can take a look at it, maybe the error comes from there

[Meglali20]

try to use npm test spec/<filename>.spec.js to run the test; again I suggest you publish your test in a PR so we can take a look at it, maybe the error comes from there

even when I don't edit anything (trying to run a test over the cloned repo without modification) and try to run a test i get the same error, when I try to run a test on a specific file I get the following error

npm test spec/CloudCode.spec.js

> parse-server@5.0.0-alpha.13 pretest C:\Users\megla\Desktop\Parse\parse-server
> cross-env MONGODB_VERSION=${MONGODB_VERSION:=4.4.10} MONGODB_TOPOLOGY=${MONGODB_TOPOLOGY:=standalone} MONGODB_STORAGE_ENGINE=${MONGODB_STORAGE_ENGINE:=wiredTiger} mongodb-runner start     

  | Starting a MongoDB deployment to test against...Error: Could not find version matching {
  version: '${MONGODB_VERSION:=4.4.10}',
  arch: [ 'x86_64', 'x64' ],
  platform: 'win32',
  target: [
    { value: 'windows', priority: 1 },
    { value: 'windows_x86_64', priority: 10 },
    { value: 'windows_x86_64-2008plus', priority: 10 },
    { value: 'windows_x86_64-2008plus-ssl', priority: 100 },
    { value: 'windows_x86_64-2012plus', priority: 100 }
  ],
  enterprise: false,
  cryptd: false
}
    at resolve (C:\Users\megla\Desktop\Parse\parse-server\node_modules\mongodb-download-url\lib\index.js:153:19)
    at async getDownloadURL (C:\Users\megla\Desktop\Parse\parse-server\node_modules\mongodb-download-url\lib\index.js:245:12)
npm ERR! Test failed.  See above for more details.

I had the same issue when I published last time a failing test but it did work when I used npm run coverage, for some reason, it's not working now.

[mtrezza]

Not sure but it may be that running the test on a windows platform is causing issues. The error seems to say that mongorunner does not have a MongoDB 4.4.10 version for win32. You could try to use a different MongoDB version to run the test. That could also explain why you could run npm run coverage last time but not npm test, if both were using different MongoDB versions.

As you can see in package.json, there are some convenience scripts for other versions:

"test:mongodb:4.0.27": "npm run test:mongodb --dbversion=4.0.27",
"test:mongodb:4.2.17": "npm run test:mongodb --dbversion=4.2.17",

You can run any other DB version with npm run test:mongodb --dbversion=<DB VERSION>

Then just change the test from it to fit to only run that one test.

[Meglali20]

The issue still persists I have tried multiple versions, I even tried it on Linux but get almost a similar error "can't determine Linux flavor" problems maybe from the package side or some missing files?