feat: Improve default rateLimit options #8506
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will reformat the title to use the proper commit message syntax. |
parse-github-assistant
bot
changed the title
Thanks for opening this pull request! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #8506 +/- ##
==========================================
+ Coverage 94.19% 94.32% +0.12%
==========================================
Files 186 183 -3
Lines 14819 14515 -304
==========================================
- Hits 13959 13691 -268
+ Misses 860 824 -36 ☔ View full report in Codecov by Sentry. |
mtrezza
reviewed
Apr 14, 2023
| errorResponseMessage: 'Too many requests', | ||
| }, | ||
| { | ||
| requestPath: '/login|verifyPassword', |
There was a problem hiding this comment.
'/login|verifyPassword'
This looks strange, is that regex? If so, shouldn't it be '/(login|verifyPassword)'?
mtrezza
added
the
state:breaking
|
This is a breaking change, so we can merge this earliest in Nov/Dec 2023 for Parse Server 7. |
3 tasks
|
Closing, see #8489 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Currently, there are no default rate limits. We should at protect login and signup endpoints from being spammed.
Closes: #8489
Approach
Adds more restrictive default rate limits
Tasks