Skip to content

Large logo header in nav bar of API docs #8636

Open
@mtrezza

Description

@mtrezza

New Issue Checklist

  • I am not disclosing a vulnerability.
    I am not just asking a question.
    I have searched through existing issues.
    I can reproduce the issue with the latest version of Parse Server.

Issue Description

There's a large broken image that occupies a large part of the navigation bar.

Steps to reproduce

See http://parseplatform.org/parse-server/api/6.2.0/

image

Suggestion

Fix the link and add a small Parse logo image there.

Activity

parse-github-assistant

parse-github-assistant commented on Jun 12, 2023

@parse-github-assistant

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.
mtrezza

mtrezza commented on Jun 12, 2023

@mtrezza
MemberAuthor

@coratgerl since you did #8528 and know the code, could you take a quick look at this?

coratgerl

coratgerl commented on Jun 12, 2023

@coratgerl
Contributor

Weird because in this PR I fixed the logo url issue. With the inspector we can see the logo search ../github/parse-server-logo.png but as you can see here https://github.com/parse-community/parse-server/pull/8528/files#diff-ba6fe1dc86dcd611730372c9fb1ad2e061ec1d33d0f96d2e2ae1168d32672308L32. I removed the logo to put "Parse server". Are you sure the changes are correctly load ?

mtrezza

mtrezza commented on Jun 13, 2023

@mtrezza
MemberAuthor

I'm not sure that the title property in that PR exactly does, but it looks strange that it's changed from an img tag to simply "Parse Server". What was the reason for that?

coratgerl

coratgerl commented on Jun 14, 2023

@coratgerl
Contributor

I didn't have the correct url of the logo, but if you have a stable url we can change

mtrezza

mtrezza commented on Jun 14, 2023

@mtrezza
MemberAuthor

We could just add the image file in the PR I guess?

coratgerl

coratgerl commented on Jul 7, 2023

@coratgerl
Contributor

fix in #8642 no ? @mtrezza

mtrezza

mtrezza commented on Jul 7, 2023

@mtrezza
MemberAuthor

Not sure, the api 6.2.0 has the bug, but docs are only published for stable versions (we should probably change that and publish also for pre-releaeses). So I'd keep this open until we see whether it's fixed with the next stable release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type:docsOnly change in the docs or README

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @mtrezza@coratgerl

        Issue actions

          Large logo header in nav bar of API docs · Issue #8636 · parse-community/parse-server