Bug-fix.

Changelog excerpt:
- Log truncation not being calculated properly; Fixed.

Author: Maikuolan

Changelog.md

@@ -45,3 +45,5 @@ __*Why "v3.0.0" instead of "v1.0.0?"*__ Prior to phpMussel v3, the "phpMussel Co
 [2021.03.11; Maikuolan]: Added some missing return type declarations.
 
 [2021.04.19; Bug-fix; Maikuolan]: BuildPath could potentially trigger warnings when open_basedir is defined, causing logging, among various other internal file operations, to fail (related to PHP bug 69240); Fixed.
+
+[2021.05.01; Bug-fix; Maikuolan]: Log truncation not being calculated properly; Fixed.

src/Loader.php

@@ -8,7 +8,7 @@
  * License: GNU/GPLv2
  * @see LICENSE.txt
  *
- * This file: The loader (last modified: 2021.04.19).
+ * This file: The loader (last modified: 2021.05.01).
  */
 
 namespace phpMussel\Core;
@@ -371,17 +371,14 @@ public function __construct(
                 return false;
             }
 
-            if (!file_exists($File) || !filesize($File) || (
-                $this->Configuration['core']['truncate'] > 0 &&
-                filesize($File) >= $this->readBytes($this->Configuration['core']['truncate'])
-            )) {
+            $Truncate = $this->readBytes($this->Configuration['core']['truncate']);
+            if (!file_exists($File) || !filesize($File) || ($Truncate && filesize($File) >= $Truncate)) {
                 $WriteMode = 'wb';
                 $Data = $this->L10N->getString('error_log_header') . "\n=====\n" . $this->InstanceCache['PendingErrorLogData'];
             } else {
                 $WriteMode = 'ab';
                 $Data = $this->InstanceCache['PendingErrorLogData'];
             }
-
             $Handle = fopen($File, $WriteMode);
             if (is_resource($Handle)) {
                 fwrite($Handle, $Data);
@@ -475,7 +472,10 @@ public function readBytes(string $In, int $Mode = 0)
             return $Unit === 'B' || $Unit === 'o' ? $In . 'B' : $In . $Unit . 'B';
         }
         $Multiply = ['K' => 1024, 'M' => 1048576, 'G' => 1073741824, 'T' => 1099511627776];
-        return (int)floor($In * (isset($Multiply[$Unit]) ? $Multiply[$Unit] : 1));
+        if (isset($Multiply[$Unit])) {
+            $In *= $Multiply[$Unit];
+        }
+        return (int)floor($In);
     }
 
     /**

src/Scanner.php

@@ -8,7 +8,7 @@
  * License: GNU/GPLv2
  * @see LICENSE.txt
  *
- * This file: The scanner (last modified: 2021.03.20).
+ * This file: The scanner (last modified: 2021.05.01).
  */
 
 namespace phpMussel\Core;
@@ -105,11 +105,8 @@ public function __construct(\phpMussel\Core\Loader &$Loader)
                 'ScanErrors' => $this->Loader->InstanceCache['ScanErrors'] ?? 1,
                 'Detections' => $Detections
             ]) . "\n";
-            $WriteMode = (!file_exists($File) || (
-                $this->Loader->Configuration['core']['truncate'] > 0 &&
-                filesize($File) >= $this->Loader->readBytes($this->Loader->Configuration['core']['truncate'])
-            )) ? 'wb' : 'ab';
-
+            $Truncate = $this->Loader->readBytes($this->Loader->Configuration['core']['truncate']);
+            $WriteMode = (!file_exists($File) || ($Truncate > 0 && filesize($File) >= $Truncate)) ? 'wb' : 'ab';
             $Stream = fopen($File, $WriteMode);
             fwrite($Stream, $Data);
             fclose($Stream);
@@ -145,12 +142,9 @@ public function __construct(\phpMussel\Core\Loader &$Loader)
                 $Results = \phpMussel\Core\Loader::SAFETY . "\n" . $Results;
                 $WriteMode = 'wb';
             } else {
-                $WriteMode = (
-                    $this->Loader->Configuration['core']['truncate'] > 0 &&
-                    filesize($File) >= $this->Loader->readBytes($this->Loader->Configuration['core']['truncate'])
-                ) ? 'wb' : 'ab';
+                $Truncate = $this->Loader->readBytes($this->Loader->Configuration['core']['truncate']);
+                $WriteMode = ($Truncate > 0 && filesize($File) >= $Truncate) ? 'wb' : 'ab';
             }
-
             $Handle = fopen($File, 'ab');
             fwrite($Handle, $Results);
             fclose($Handle);