Skip to content

Commit 658bd2b

Browse files
committed
try macos builds
1 parent 3259c19 commit 658bd2b

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

.github/workflows/build-test.yml

+2-1
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,8 @@ jobs:
8383
# Setup GN
8484
# Warnings are no errors - @see https://issues.chromium.org/issues/42203398#comment9
8585
if [[ "${{ runner.os }}" == "macOS" ]]; then
86-
tools/dev/v8gen.py -vv $V8CONFIG -- target_cpu=$ARCH_SHORT v8_target_cpu=$ARCH_SHORT is_component_build=true use_custom_libcxx=true treat_warnings_as_errors=false
86+
# Run gn gen with args as v8gen does not override target_cpu properly
87+
gn gen out.gn/$V8CONFIG --args="target_cpu=$ARCH_SHORT v8_target_cpu=$ARCH_SHORT is_component_build=true use_custom_libcxx=true treat_warnings_as_errors=false"
8788
else
8889
tools/dev/v8gen.py -vv $V8CONFIG -- is_component_build=true use_custom_libcxx=true treat_warnings_as_errors=false
8990
fi

0 commit comments

Comments
 (0)