debug pipeline

Author: JoshuaBehrens

.github/workflows/build-test.yml

@@ -97,8 +97,30 @@ jobs:
                     else
                         LIB_EXT=so
                     fi
-                    cp out.gn/$V8CONFIG/lib*.${LIB_EXT} out.gn/$V8CONFIG/*_blob.bin out.gn/$V8CONFIG/icudtl.dat /opt/v8/self-built/lib/
+                    # Copy all V8 libraries and support files
+                    cp -v out.gn/$V8CONFIG/lib*.${LIB_EXT}* out.gn/$V8CONFIG/*_blob.bin out.gn/$V8CONFIG/icudtl.dat /opt/v8/self-built/lib/
+                    # Copy all V8 static libraries as well
+                    cp -v out.gn/$V8CONFIG/obj/libv8_*.a /opt/v8/self-built/lib/ 2>/dev/null || true
+                    # Copy headers
                     cp -R include/* /opt/v8/self-built/include/
+                    # Create symlinks for libraries without version numbers
+                    cd /opt/v8/self-built/lib/
+                    for lib in lib*.${LIB_EXT}.*; do
+                        if [[ $lib == *\.${LIB_EXT}.* ]]; then
+                            ln -sf $lib ${lib%%.*} 2>/dev/null || true
+                        fi
+                    done
+                    # Set library search path
+                    if [[ "${{ runner.os }}" == "Linux" ]]; then
+                        echo "/opt/v8/self-built/lib" | sudo tee /etc/ld.so.conf.d/v8.conf
+                        sudo ldconfig
+                    elif [[ "${{ runner.os }}" == "macOS" ]]; then
+                        # On macOS, update DYLD_LIBRARY_PATH for the current session
+                        echo "DYLD_LIBRARY_PATH=/opt/v8/self-built/lib" >> $GITHUB_ENV
+                        # Also create symlinks in /usr/local/lib for system-wide access
+                        sudo mkdir -p /usr/local/lib/v8
+                        sudo ln -sf /opt/v8/self-built/lib/*.dylib* /usr/local/lib/v8/
+                    fi
 
                     # Go back to origin
                     cd "${GITHUB_WORKSPACE}"
@@ -158,9 +180,46 @@ jobs:
 
             -   name: Build extension
                 run: |
+                    # Set library paths based on OS
+                    if [[ "${{ runner.os }}" == "Linux" ]]; then
+                        export LD_LIBRARY_PATH="/opt/v8/self-built/lib:${LD_LIBRARY_PATH:-}"
+                        # Ensure linker can find the libraries
+                        echo "/opt/v8/self-built/lib" | sudo tee /etc/ld.so.conf.d/v8js.conf
+                        sudo ldconfig
+                        echo "=== Library search paths ==="
+                        ldconfig -p | grep v8 || true
+                    elif [[ "${{ runner.os }}" == "macOS" ]]; then
+                        export DYLD_LIBRARY_PATH="/opt/v8/self-built/lib:${DYLD_LIBRARY_PATH:-}"
+                    fi
+                    
+                    # List V8 libraries for debugging
+                    echo "=== Available V8 libraries ==="
+                    ls -la /opt/v8/self-built/lib/
+                    
+                    # Build the extension
                     phpize
-                    ./configure --with-v8js=/opt/v8/self-built LDFLAGS="-lstdc++" CPPFLAGS="-DV8_COMPRESS_POINTERS -DV8_ENABLE_SANDBOX"
-                    make
+                    
+                    # Configure with explicit library paths
+                    echo "=== Running configure ==="
+                    ./configure \
+                        --with-v8js=/opt/v8/self-built \
+                        LDFLAGS="-L/opt/v8/self-built/lib -Wl,-rpath=/opt/v8/self-built/lib" \
+                        CPPFLAGS="-I/opt/v8/self-built/include -DV8_COMPRESS_POINTERS -DV8_ENABLE_SANDBOX" \
+                        LIBS="-lstdc++" \
+                        V8_LIBS="-L/opt/v8/self-built/lib -lv8 -lv8_libplatform -lv8_libbase -lstdc++ -lpthread -ldl"
+                    
+                    # Build with verbose output
+                    echo "=== Building extension ==="
+                    make -j$(nproc) V=1
+                    
+                    # Verify the linked libraries
+                    if [[ "${{ runner.os }}" == "Linux" ]]; then
+                        echo "=== Checking linked libraries ==="
+                        ldd modules/v8js.so | grep -i v8 || true
+                    fi
+                    
+                    # Run tests
+                    echo "=== Running tests ==="
                     make test
 
             -   name: Archive test results