[Bug]: Classes with missing internal (#241)

lukmzig · web-flow · commit 81fbc6b3bd27 · 2024-11-15T08:06:31.000+01:00
* fix: add forgotten internal tags

* Apply php-cs-fixer changes

* fix: abstract adapters should not be internal

---------

Co-authored-by: lukmzig &lt;lukmzig@users.noreply.github.com&gt;
diff --git a/src/SearchIndexAdapter/OpenSearch/DataObject/IndexIconUpdateService.php b/src/SearchIndexAdapter/OpenSearch/DataObject/IndexIconUpdateService.php
@@ -22,7 +22,6 @@
 
 /**
  * @internal
-
  */
 final readonly class IndexIconUpdateService implements IndexIconUpdateServiceInterface
 {
diff --git a/src/SearchIndexAdapter/OpenSearch/IndexMappingService.php b/src/SearchIndexAdapter/OpenSearch/IndexMappingService.php
@@ -23,6 +23,9 @@
 use Pimcore\Bundle\GenericDataIndexBundle\SearchIndexAdapter\Mapping;
 use Pimcore\Model\DataObject\ClassDefinition\Data;
 
+/**
+ * @internal
+ */
 readonly class IndexMappingService implements IndexMappingServiceInterface
 {
     public function __construct(
diff --git a/src/SearchIndexAdapter/OpenSearch/IndexStatsService.php b/src/SearchIndexAdapter/OpenSearch/IndexStatsService.php
@@ -26,6 +26,9 @@
 use Pimcore\Bundle\GenericDataIndexBundle\Service\SearchIndex\SearchIndexConfigServiceInterface;
 use Pimcore\Bundle\GenericDataIndexBundle\Traits\LoggerAwareTrait;
 
+/**
+ * @internal
+ */
 final class IndexStatsService implements IndexStatsServiceInterface
 {
     use LoggerAwareTrait;
diff --git a/src/SearchIndexAdapter/OpenSearch/QueryLanguage/FieldNameValidator/FieldExistsValidator.php b/src/SearchIndexAdapter/OpenSearch/QueryLanguage/FieldNameValidator/FieldExistsValidator.php
@@ -21,6 +21,9 @@
 use Pimcore\Bundle\GenericDataIndexBundle\SearchIndexAdapter\OpenSearch\QueryLanguage\FieldNameValidatorInterface;
 use Symfony\Component\DependencyInjection\Attribute\AsTaggedItem;
 
+/**
+ * @internal
+ */
 #[AsTaggedItem(priority: 0)]
 final readonly class FieldExistsValidator implements FieldNameValidatorInterface
 {
diff --git a/src/SearchIndexAdapter/OpenSearch/QueryLanguage/FieldNameValidator/LocalizedFieldValidator.php b/src/SearchIndexAdapter/OpenSearch/QueryLanguage/FieldNameValidator/LocalizedFieldValidator.php
@@ -22,6 +22,9 @@
 use Pimcore\Tool;
 use Symfony\Component\DependencyInjection\Attribute\AsTaggedItem;
 
+/**
+ * @internal
+ */
 #[AsTaggedItem(priority: 1)]
 final readonly class LocalizedFieldValidator implements FieldNameValidatorInterface
 {
diff --git a/src/SearchIndexAdapter/OpenSearch/QueryLanguage/FieldNameValidator/RelationValidator.php b/src/SearchIndexAdapter/OpenSearch/QueryLanguage/FieldNameValidator/RelationValidator.php
@@ -21,6 +21,9 @@
 use Pimcore\Bundle\GenericDataIndexBundle\SearchIndexAdapter\OpenSearch\QueryLanguage\FieldNameValidatorInterface;
 use Symfony\Component\DependencyInjection\Attribute\AsTaggedItem;
 
+/**
+ * @internal
+ */
 #[AsTaggedItem(priority: 2)]
 final readonly class RelationValidator implements FieldNameValidatorInterface
 {
diff --git a/src/SearchIndexAdapter/OpenSearch/Search/FetchIdsBySearchService.php b/src/SearchIndexAdapter/OpenSearch/Search/FetchIdsBySearchService.php
@@ -24,6 +24,9 @@
 use Pimcore\Bundle\GenericDataIndexBundle\SearchIndexAdapter\SearchIndexServiceInterface;
 use Pimcore\Bundle\GenericDataIndexBundle\Service\SearchIndex\SearchIndexConfigServiceInterface;
 
+/**
+ * @internal
+ */
 final readonly class FetchIdsBySearchService implements FetchIdsBySearchServiceInterface
 {
     public function __construct(

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,6 @@`
`22`	`22`
`23`	`23`	`/**`
`24`	`24`	`* @internal`
`25`		`-`
`26`	`25`	`*/`
`27`	`26`	`final readonly class IndexIconUpdateService implements IndexIconUpdateServiceInterface`
`28`	`27`	`{`
Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,9 @@`
`23`	`23`	`use Pimcore\Bundle\GenericDataIndexBundle\SearchIndexAdapter\Mapping;`
`24`	`24`	`use Pimcore\Model\DataObject\ClassDefinition\Data;`
`25`	`25`
	`26`	`+/**`
	`27`	`+ * @internal`
	`28`	`+ */`
`26`	`29`	`readonly class IndexMappingService implements IndexMappingServiceInterface`
`27`	`30`	`{`
`28`	`31`	`public function __construct(`
Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,9 @@`
`26`	`26`	`use Pimcore\Bundle\GenericDataIndexBundle\Service\SearchIndex\SearchIndexConfigServiceInterface;`
`27`	`27`	`use Pimcore\Bundle\GenericDataIndexBundle\Traits\LoggerAwareTrait;`
`28`	`28`
	`29`	`+/**`
	`30`	`+ * @internal`
	`31`	`+ */`
`29`	`32`	`final class IndexStatsService implements IndexStatsServiceInterface`
`30`	`33`	`{`
`31`	`34`	`use LoggerAwareTrait;`
Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,9 @@`
`21`	`21`	`use Pimcore\Bundle\GenericDataIndexBundle\SearchIndexAdapter\OpenSearch\QueryLanguage\FieldNameValidatorInterface;`
`22`	`22`	`use Symfony\Component\DependencyInjection\Attribute\AsTaggedItem;`
`23`	`23`
	`24`	`+/**`
	`25`	`+ * @internal`
	`26`	`+ */`
`24`	`27`	`#[AsTaggedItem(priority: 0)]`
`25`	`28`	`final readonly class FieldExistsValidator implements FieldNameValidatorInterface`
`26`	`29`	`{`
Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,9 @@`
`22`	`22`	`use Pimcore\Tool;`
`23`	`23`	`use Symfony\Component\DependencyInjection\Attribute\AsTaggedItem;`
`24`	`24`
	`25`	`+/**`
	`26`	`+ * @internal`
	`27`	`+ */`
`25`	`28`	`#[AsTaggedItem(priority: 1)]`
`26`	`29`	`final readonly class LocalizedFieldValidator implements FieldNameValidatorInterface`
`27`	`30`	`{`
Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,9 @@`
`24`	`24`	`use Pimcore\Bundle\GenericDataIndexBundle\SearchIndexAdapter\SearchIndexServiceInterface;`
`25`	`25`	`use Pimcore\Bundle\GenericDataIndexBundle\Service\SearchIndex\SearchIndexConfigServiceInterface;`
`26`	`26`
	`27`	`+/**`
	`28`	`+ * @internal`
	`29`	`+ */`
`27`	`30`	`final readonly class FetchIdsBySearchService implements FetchIdsBySearchServiceInterface`
`28`	`31`	`{`
`29`	`32`	`public function __construct(`