Impved tasks documentation

Author: jacek-marchwicki

plugin/src/main/java/com/appunite/firebasetestlabplugin/FirebaseTestLabPlugin.kt

@@ -73,6 +73,9 @@ internal class FirebaseTestLabPlugin : Plugin<Project> {
                 val gsutil = File(sdkPath, Constants.GSUTIL)
 
                 project.task(ensureGCloudSdk, {
+                    group = Constants.FIREBASE_TEST_LAB
+                    description = "Check if google cloud sdk is installed"
+
                     doFirst {
                         if (!gcloud.exists()) {
                             throw IllegalStateException("gcloud does not exist in path ${sdkPath.absoluteFile}, but downloading is not supported on Windows")
@@ -99,6 +102,9 @@ internal class FirebaseTestLabPlugin : Plugin<Project> {
                 val gsutil = File(sdkPath, Constants.GSUTIL)
 
                 project.createTask(ensureGCloudSdk, HiddenExec::class, {
+                    group = Constants.FIREBASE_TEST_LAB
+                    description = "Install google cloud SDK if necessary"
+
                     outputs.files(gcloud, gsutil)
                     doFirst {
                         if (Os.isFamily(Os.FAMILY_WINDOWS)) {
@@ -127,6 +133,9 @@ internal class FirebaseTestLabPlugin : Plugin<Project> {
             val sdk = createDownloadSdkTask(project, cloudSdkPath)
 
             project.createTask(taskAuth, HiddenExec::class, {
+                group = Constants.FIREBASE_TEST_LAB
+                description = "Authorize google cloud sdk"
+
                 dependsOn(ensureGCloudSdk)
                 val keyFile = keyFile
                 doFirst {
@@ -139,6 +148,9 @@ internal class FirebaseTestLabPlugin : Plugin<Project> {
                 commandLine = listOf(sdk.gcloud.absolutePath, "auth", "activate-service-account", "--key-file=${keyFile?.absolutePath}")
             })
             project.createTask(taskSetProject, HiddenExec::class, {
+                group = Constants.FIREBASE_TEST_LAB
+                description = "Configure google cloud sdk project"
+
                 dependsOn(ensureGCloudSdk)
                 doFirst {
                     if (googleProjectId == null) {
@@ -148,6 +160,9 @@ internal class FirebaseTestLabPlugin : Plugin<Project> {
                 commandLine = listOf(sdk.gcloud.absolutePath, "config", "set", "project", "$googleProjectId")
             })
             project.task(taskSetup, {
+                group = Constants.FIREBASE_TEST_LAB
+                description = "Setup and configure google cloud sdk"
+
                 dependsOn(taskSetProject)
                 dependsOn(taskAuth)
             })
@@ -177,9 +192,6 @@ internal class FirebaseTestLabPlugin : Plugin<Project> {
                     project.logger
             )
 
-
-
-
             (project.extensions.findByName(ANDROID) as AppExtension).apply {
                 testVariants.toList().forEach { testVariant ->
                     createGroupedTestLabTask(TestType.INSTRUMENTATION, devices, testVariant, firebaseTestLabProcessCreator, ignoreFailures, downloader)
@@ -209,7 +221,7 @@ internal class FirebaseTestLabPlugin : Plugin<Project> {
         if (downloader != null) {
             project.task(cleanTask, closureOf<Task> {
                 group = Constants.FIREBASE_TEST_LAB
-                description = "Clean test lab artifacts"
+                description = "Clean test lab artifacts on google storage"
                 dependsOn(taskSetup)
                 doLast {
                     downloader.clearResultsDir()
@@ -257,6 +269,8 @@ internal class FirebaseTestLabPlugin : Plugin<Project> {
                 }
 
         project.task(runTestsTask, closureOf<Task> {
+            group = Constants.FIREBASE_TEST_LAB
+            description = "Run Android Tests in Firebase Test Lab"
             dependsOn(tasks)
 
             doFirst {
@@ -278,7 +292,7 @@ internal class FirebaseTestLabPlugin : Plugin<Project> {
         if (downloader != null) {
             project.task(downloadTask, closureOf<Task> {
                 group = Constants.FIREBASE_TEST_LAB
-                description = "Run Android Tests in Firebase Test Lab and download artifacts"
+                description = "Run Android Tests in Firebase Test Lab and download artifacts from google storage"
                 dependsOn(taskSetup)
                 dependsOn(runTestsTask)
                 mustRunAfter(cleanTask)

plugin/src/main/java/com/appunite/firebasetestlabplugin/model/Device.kt

@@ -9,14 +9,6 @@ class Device(val name: String) {
 
     var testUniversalApk: Boolean = true
 
-    fun filterAbis(vararg filter: String) {
-        abiSplits = setOf(*filter)
-        filterAbiSplits = true
-    }
-    fun filterAbis(filter: Set<String>) {
-        abiSplits = filter
-        filterAbiSplits = true
-    }
     var filterAbiSplits = false
     var abiSplits: Set<String> = setOf()
 }

plugin/src/test/java/com/appunite/firebasetestlabplugin/IntegrationTest.kt

@@ -254,7 +254,7 @@ class IntegrationTest {
             keyFile = File(simpleProject, "key.json")
             createDevice("myDevice", {
                 deviceIds = listOf("Nexus6")
-                filterAbis()
+                filterAbiSplits = true
             })
         }
         (project as ProjectInternal).evaluate()