Skip to content

Incorrect type definitions causing confusion when trying to catch PostgresError #862

Open
@michalkvasnicak

Description

@michalkvasnicak

I noticed that when I want to catch an error and identify it using instanceof I got an error TypeError: Right-hand side of 'instanceof' is not an object. Which was caused by following code:

import { PostgresError } from 'postgres';

try {
  // await query
} catch (e) {
  if (e instanceof PostgresError) {
    // do something
  }
}

To fix that I had to use default import:

import Postgres from 'postgres';

try {
  // await query
} catch (e) {
  if (e instanceof Postgres.PostgresError) {
    // do something
  }
}

This is confusing because typescript was not able to catch the failing example as something wrong and I was able to find this error only in runtime.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions