Devendor pe_* modules

[bastelfreak]

Use Case

This is a followup of many slack conversations and vox pupuli monthlies. PE vendors and rebrands a few modules, for example inifile, postgresql and hocon. There's also code for managing PuppetDB that was once copied into the puppetlabs/puppetdb module or vice versa. The puppetlabs/puppetdb module has a history of poor maintenance and code quality. Puppet even wanted to stop working on it: puppetlabs/puppetlabs-puppetdb#378.

I think this is bad practice. Instead Puppet engineers should work on open source modules and not on open source versions + internal forks.

Describe the Solution You Would Like

Stop rebranding modules, rely on the open source versions.

Describe Alternatives You've Considered

Additional Context

https://github.com/voxpupuli/community-triage/wiki#january-9-2024 has some talking points.

[bastelfreak]

A bit more context:
The modules were vendored and prefixed with pe_ because their location, /opt/puppetlabs/puppet/modules/ is added to the basemodulepath. And the prefix was used to avoid collisions. I think instead /opt/puppetlabs/puppet/modules/ should be its own environment that PE uses. That would also be the appropriate fix for the bug in puppetlabs/puppetlabs-peadm#469 . At the moment PE assumes that the production environment always exists (and the basemodulepath contains /opt/puppetlabs/puppet/modules/). But this isn't always true.