Skip to content

Remove old amdlib code #1387

Open
Open
@ricardoV94

Description

@ricardoV94

Description

Some of our ScalarOps have amd_float32 and amd_float64 properties to be used by the Elemwise C-code in contiguous cases. These operators like amd_vrda_log correspond to an old / sunsetted amd math library: https://en.wikipedia.org/wiki/AMD_Core_Math_Library

The changes were introduced in 2013

The code is also untested (and I think broken). We should remove it for now. SIMD is a deep rabbit hole of its own. If someone wanted to work on this, it would probably make sense to use something modern and more portable like google's Highway: https://github.com/google/highway

This is what numpy is transitioting towards for their SIMD use-cases

It is also available on conda-forge and thus much easier for end-users to install.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @ricardoV94

        Issue actions

          Remove old amdlib code · Issue #1387 · pymc-devs/pytensor