Skip to content

pytester.Testdir.plugins is confusing and clunky #2126

Open
@goodboy

Description

@goodboy

pytester.TestDir.plugins is used two different ways:

I propose just getting rid of it and instead having runpytest_subprocess and parseconfig accept it as a keyword arg like inline_run does.

It's also awkward that you have to manually mutate the list in order to use it.

Activity

nicoddemus

nicoddemus commented on Sep 29, 2017

@nicoddemus
Member

I'm fine with it: never used and in pytest's code base it is only used by test_resultlog.py in 3 places.

added
plugin: pytesterrelated to the pytester builtin plugin
type: backward compatibilitymight present some backward compatibility issues which should be carefully noted in the changelog
on Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    plugin: pytesterrelated to the pytester builtin plugintype: backward compatibilitymight present some backward compatibility issues which should be carefully noted in the changelogtype: refactoringinternal improvements to the code

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @goodboy@nicoddemus

        Issue actions

          pytester.Testdir.plugins is confusing and clunky · Issue #2126 · pytest-dev/pytest