Skip to content

gh-132426: get_annotate_function vs. mapping namespaces #132427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

eliegoudout
Copy link

@eliegoudout eliegoudout commented Apr 12, 2025

Signed-off-by: Élie Goudout <eliegoudout@hotmail.com>
@python-cla-bot
Copy link

python-cla-bot bot commented Apr 12, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Apr 12, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@picnixz picnixz changed the title fix annotationlib: namespace can be mapping (closes #132426) gh-132426: get_annotate_function should allow mapping-like objects Apr 12, 2025
@eliegoudout
Copy link
Author

I convert back to draft because of this.

@eliegoudout eliegoudout marked this pull request as draft April 12, 2025 08:58
@eliegoudout eliegoudout changed the title gh-132426: get_annotate_function should allow mapping-like objects gh-132426: get_annotate_function vs. mapping namespaces Apr 12, 2025
Signed-off-by: Élie Goudout <eliegoudout@hotmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Apr 12, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

annotationlib: namespace can be non-dict
2 participants