Skip to content

TypeChecker.lookup_qualified can't find names in submodules #14954

Open
@embray

Description

@embray

Bug Report

Writing my first mypy plugin, I tried to use the exposed interface ctx.api.named_generic_type to look up a type in my package by name, which is in a submodule like:

ctx.api.named_generic_type('foo.bar.baz.Qux', [])

In this case ctx is a FunctionContext but it applies to most (all?) relevant plugin hook contexts.

The name is not found because foo.bar.baz is a submodule.

To Reproduce

See above.

Expected Behavior

Since this is the only public API for looking up named types, it should be possible--especially for plugins that could be intended for some specific third-party libraries--to be able to look into nested module namespaces.

Actual Behavior

The current implementation uses lookup_qualified which as written assumes that only the first component of a dotted name is necessarily a module name. It then looks into the symbol table for that module to find subsequent name components. This works fine for type lookups like typing.Type but not for other cases, as there is no guarantee that a submodule name is found in its parent module's namespace.

Probably should check the symbol table first, and if not found try the next component as a module name.

To work around this, have to dig into the undocumented TypeChecker.modules to find the required type.

Your Environment

  • Mypy version used: 1.1.1
  • Mypy command-line flags: N/A
  • Mypy configuration options from mypy.ini (and other config files): N/A
  • Python version used: 3.9

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugmypy got something wrongtopic-pluginsThe plugin API and ideas for new plugins

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions