Mypy 1.5 Release Planning

[svalentin]

Planning to make the 1.5 release around middle of July.

Please post here any issues you'd like to see fixed in the release, or PRs you'd like to have merged. Will make the release branch as release-1.5.

[svalentin]

Looks like typeshed syncing is having a conflict when cherry picking "Remove use of LiteralString in builtins" (6f913a148)
https://github.com/python/mypy/actions/workflows/sync_typeshed.yml

[AlexWaygood]

Looks like typeshed syncing is having a conflict when cherry picking "Remove use of LiteralString in builtins" (6f913a148) https://github.com/python/mypy/actions/workflows/sync_typeshed.yml

Here you go:

• Sync typeshed #15590

I'm pretty seasoned with these by now 😆

[svalentin]

Ah, thanks! :D

[cdce8p]

I would like to see this included. It's just missing a final review.

• Add strict_override_decorator option (PEP 698) #15512

[cdce8p]

Small fix for a sqlalchemy issue with the PEP 681 implementation

• Support optional for custom dataclass descriptors #15628

[ikonst]

Fixes a crash introduced in 1.4:

• Fix dataclass/protocol crash on joining types #15629

[svalentin]

Looks like we have a typeshed bug:

from unittest.mock import patch

def addition(a: int, b:int) -> int:
    return a+b

@patch('test.addition')
def patch_test(mock):
    print(mock)

if __name__ == "__main__":
    patch_test()

In this simple example mypy says:

test.py:12: error: Missing positional argument "mock" in call to "patch_test"  [call-arg]

Undoing python/typeshed@9e86c60 fixes it
Filed python/typeshed#10457 for record keeping

[cdce8p]

A usability improvement with invalid generic instances. This PR reuses existing args whenever possible instead of replacing everything with Any. This would match the pyright behavior.

• Better fill invalid generic instances #15656

[sobolevn]

I think that this is important enough to have a special note: #15668

[svalentin]

I think it's best if we leave #15668 for the next release

[svalentin]

Created the release-1.5 branch

[svalentin]

Hmm, I think we have an issue, but can't find out what changed. Did we remove typeshed for attr or something like that?

For this example

import attr

@attr.s(frozen=True)
class SomeProperties(object):
    x = attr.ib(type=str)
    y = attr.ib(type=int)

for field in attr.fields(SomeProperties):
    print(field.name)
    print(field.metadata)

mypy-1.4.1 finds no issues, but master (and release-1.5):

test2.py:9: error: "object" has no attribute "name"  [attr-defined]
test2.py:10: error: "object" has no attribute "metadata"  [attr-defined]
Found 2 errors in 1 file (checked 1 source file)

The issue is type should be attr.Attribute, not object

[cdce8p]

Hmm, I think we have an issue, but can't find out what changed. Did we remove typeshed for attr or something like that?

You might want to revert #15021 for 1.5, too. That was one of the first commits in the release-1.4 branch. 3bf9fdc